fix(js): support rootDir in node executor #33584
Open
+220
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node executor now correctly handles TypeScript's rootDir configuration when calculating output file paths. closed nrwl#33577
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node executor now correctly handles TypeScript's rootDir configuration when calculating output file paths.
Current Behavior
A Nx project has a build target using
@nx/js:tscwith options:rootDir: "{projectRoot}/src"main: "{projectRoot}/src/main.ts"Running
nx buildcorrectly generatesmain.jsindist/apps/project_arespectingrootDir.However, the serve target (@nx/js:node) fails.
Expected Behavior
The
servetarget runs without errors.The
@nx/js:nodeexecutor correctly resolves the built JS file’s path, respecting therootDirconfiguration, instead of incorrectly addingsrcunderdist.Related Issue(s)
Fixes #33577 where rootDir breaks js:node executor.