feat(angular-rspack): Add "zoneless" option to enable Angular's provideZonelessChangeDetection() usage
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization within PrerenderPlugin
vz-tl
reviewed
Jun 13, 2025
| @@ -265,6 +265,7 @@ export async function normalizeOptions( | |||
| vendorChunk: options.vendorChunk ?? false, | |||
| verbose: options.verbose ?? false, | |||
| watch: options.watch ?? false, | |||
| zoneless: options.zoneless ?? false, | |||
There was a problem hiding this comment.
suggestion: I'm questioning a bit the requirement of a dedicated config option for zoneless support, as
- running zoneless actually could be inferred by the absence of 'zone.js' in the
polyfillsconfig option - additionally, based on your changes it seems to only affect SSR respectively pre-rendering. So if a dedicated config option would really be a requirement, maybe it fits better to add it to
ssrorprerender?
There was a problem hiding this comment.
running zoneless actually could be inferred by the absence of 'zone.js' in the polyfillsconfig option
That'd be better I think; wasn't sure If such implicit behaviour might be breaking, or not. I guess it will do a lot more good, then bad.
Will make this change, thanks for review.
vz-tl
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
"zoneless"property toAngularRspackPluginOptions, soPrerenderPluginis capable of skipping "zone.js" initialisation.I tried using rspack to build my Angular SSR application without "zone.js" and
PrerenderPlugindid complain about missing dependency.Suggestion