lib: at_host: Write AT response to correct UART device #20382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
anhmolt
force-pushed
the
write-at-resp-to-correct-uart-dev
branch
from
efada76 to
ce35d19
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 0f81d3e085de3fc73ed59f88b34b66c5c8a35768 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
rlubos
approved these changes
Feb 14, 2025
Use preprocessor macro to get the uart device to use. Signed-off-by: Andreas Moltumyr <[email protected]>
Ensure that AT responses are written to the correct UART device when CONFIG_LOG_BACKEND_UART is enabled and ncs,at-host-uart is not uart0 (default). Co-authored-by: Fredrik Flornes Ellertsen <[email protected]> Signed-off-by: Andreas Moltumyr <[email protected]>
anhmolt
force-pushed
the
write-at-resp-to-correct-uart-dev
branch
from
ce35d19 to
0f81d3e
Compare
github-actions
bot
added
doc-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for instance trying to use
uart3for the AT host whileCONFIG_LOG_BACKEND_UARTis enabled, AT responses all ended up in the log, not on the chosen AT host UART device.This builds on PR #20242 by @fellerts, where a fix for this issue was first posted.