-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESB, Radio Test: Add support for new 4Mbit mode configurations #17210
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 268762e585394ac8c2e4039340ab05a22693540f more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)
Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
a29ea3a
to
653493a
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
653493a
to
7da8528
Compare
We have a test PR to add this to CI, and would appreciate if you could rebase with latest sdk-nrf main, since this branch is out of date 🙂 https://projecttools.nordicsemi.no/bitbucket/projects/NCS-TEST/repos/test-fw-nrfconnect-proprietary/pull-requests/77/overview |
7da8528
to
33e1aa8
Compare
Adds support for new 4Mbit PHY configurations including `RADIO_MODE_MODE_Nrf_4Mbit_0BT6` and `RADIO_MODE_MODE_Nrf_4Mbit_0BT4`. Ref: NCSDK-29045 Signed-off-by: Marcin Jelinski <[email protected]>
Adds support for `RADIO_MODE_MODE_Nrf_4Mbit_0BT6` Ref: NCSDK-29045 Signed-off-by: Marcin Jelinski <[email protected]>
33e1aa8
to
268762e
Compare
#if defined(RADIO_MODE_MODE_Nrf_4Mbit_0BT6) | ||
/** 4 Mb radio mode. */ | ||
ESB_BITRATE_4MBPS = RADIO_MODE_MODE_Nrf_4Mbit_0BT6, | ||
#endif /* defined(RADIO_MODE_MODE_Nrf_4Mbit_0BT6) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two #if defined
conditions defines single enum item with a different value. Are the conditions always mutually exclusive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RADIO_MODE_MODE_Nrf_4Mbit0_5
exists for the nRF54H20, while RADIO_MODE_MODE_Nrf_4Mbit_0BT6
exists for the nRF54L15.
Adds support for new 4Mbit PHY configurations including
RADIO_MODE_MODE_Nrf_4Mbit_0BT6
andRADIO_MODE_MODE_Nrf_4Mbit_0BT4
.