Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESB, Radio Test: Add support for new 4Mbit mode configurations #17210

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

maje-emb
Copy link
Contributor

@maje-emb maje-emb commented Sep 5, 2024

Adds support for new 4Mbit PHY configurations including
RADIO_MODE_MODE_Nrf_4Mbit_0BT6 and RADIO_MODE_MODE_Nrf_4Mbit_0BT4.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 5, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 5, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 268762e585394ac8c2e4039340ab05a22693540f

more details

sdk-nrf:

PR head: 268762e585394ac8c2e4039340ab05a22693540f
merge base: 858a047e118aac8a330b86896272f0c0d77d88ef
target head (main): 678514e395cf54968863bdbe878aa1314856c69b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
include
│  │ esb.h
samples
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── src
│  │  │  │  ├── radio_cmd.c
│  │  │  │  │ radio_test.c
subsys
│  ├── esb
│  │  │ esb.c

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 75
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-proprietary_esb
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@maje-emb maje-emb marked this pull request as draft September 5, 2024 14:58
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@stephen-nordic
Copy link
Contributor

We have a test PR to add this to CI, and would appreciate if you could rebase with latest sdk-nrf main, since this branch is out of date 🙂 https://projecttools.nordicsemi.no/bitbucket/projects/NCS-TEST/repos/test-fw-nrfconnect-proprietary/pull-requests/77/overview

Adds support for new 4Mbit PHY configurations including
`RADIO_MODE_MODE_Nrf_4Mbit_0BT6` and `RADIO_MODE_MODE_Nrf_4Mbit_0BT4`.

Ref: NCSDK-29045

Signed-off-by: Marcin Jelinski <[email protected]>
Adds support for `RADIO_MODE_MODE_Nrf_4Mbit_0BT6`

Ref: NCSDK-29045

Signed-off-by: Marcin Jelinski <[email protected]>
@maje-emb maje-emb marked this pull request as ready for review October 1, 2024 09:36
@maje-emb maje-emb requested review from a team as code owners October 1, 2024 09:36
#if defined(RADIO_MODE_MODE_Nrf_4Mbit_0BT6)
/** 4 Mb radio mode. */
ESB_BITRATE_4MBPS = RADIO_MODE_MODE_Nrf_4Mbit_0BT6,
#endif /* defined(RADIO_MODE_MODE_Nrf_4Mbit_0BT6) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two #if defined conditions defines single enum item with a different value. Are the conditions always mutually exclusive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RADIO_MODE_MODE_Nrf_4Mbit0_5 exists for the nRF54H20, while RADIO_MODE_MODE_Nrf_4Mbit_0BT6 exists for the nRF54L15.

@maje-emb maje-emb added this to the 2.8.0 milestone Oct 8, 2024
@rlubos rlubos merged commit 3ef4c4d into nrfconnect:main Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants