[DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200

Vge0rge · 2024-09-05T11:05:57Z

No description provided.

NordicBuilder · 2024-09-05T11:06:32Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`015b317`	nrfconnect/sdk-zephyr#2008	nrfconnect/sdk-zephyr#2008/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-09-05T11:07:05Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 35

Inputs:

Sources:

sdk-nrf: PR head: 1a81cacc90c15dfc27d77f73bf17f789dddb8f3b
zephyr: PR head: 0b1e91ca4c2d9605003f7a4cbca05e9719d48645

more details

sdk-nrf:

PR head: 1a81cacc90c15dfc27d77f73bf17f789dddb8f3b
merge base: a07804cccb31616bff75ffb0fcfb81febdbdc016
target head (main): a07804cccb31616bff75ffb0fcfb81febdbdc016
Diff

zephyr:

PR head: 0b1e91ca4c2d9605003f7a4cbca05e9719d48645
merge base: 015b317bc3242161f731a14a76333ad6c5d7f47d
target head (main): 3440378f9918e9ccdfbe6b08edcf0de593f0f0bd
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (19)

applications
│  ├── matter_bridge
│  │  ├── sysbuild
│  │  │  ├── ipc_radio
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.conf
samples
│  ├── suit
│  │  ├── flash_companion
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  ├── smp_transfer
│  │  │  ├── sysbuild
│  │  │  │  │ nrf54h20dk_nrf54h20_memory_map.dtsi
subsys
│  ├── CMakeLists.txt
│  ├── nrf_security
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── Kconfig.psa
│  │  ├── include
│  │  │  │ ssf_crypto_config_empty.h
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  │ Kconfig
│  │  │  ├── ssf_secdom
│  │  │  │  │ Kconfig
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.dts
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.dts
│  ├── drivers
│  │  ├── entropy
│  │  │  │ Kconfig.psa_crypto
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54h
│  │  │  │  │ Kconfig
│  ├── tests
│  │  ├── crypto
│  │  │  ├── mbedtls
│  │  │  │  │ testcase.yaml
│  │  │  ├── mbedtls_psa
│  │  │  │  │ testcase.yaml
│  │  │  ├── secp256r1
│  │  │  │  │ testcase.yaml
│  │  ├── subsys
│  │  │  ├── portability
│  │  │  │  ├── cmsis_rtos_v2
│  │  │  │  │  │ prj.conf

Outputs:

Toolchain

Version: b44b7a08c9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b44b7a08c9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 1680
- sdk-zephyr test count: 6293
❌ Integration tests
- ✅ test-sdk-audio
- ❌ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf_crypto
- ❌ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-tfm
- ✅ test-fw-nrfconnect-thread
- ✅ test-sdk-find-my
- ✅ test-sdk-sidewalk
- ❌ test-low-level
- ❌ test-sdk-dfu
- ⚠️ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-zigbee
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-09-24T11:15:56Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

tomi-font

Again in this PR you have a commit that is later reverted (nrf_security: Enabled by default for nRF54H20)?

subsys/nrf_security/Kconfig

tomi-font · 2024-10-03T15:53:23Z

subsys/nrf_security/Kconfig

@@ -30,6 +30,12 @@ config NORDIC_SECURITY_BACKEND
 	  Note that this will enable nrf_oberon by default. Multiple backends is
 	  not supported.

+config PSA_SSF_CRYPTO_CLIENT
+	bool
+	prompt "PSA crypto provided through SSF"


Define what SSF stands for?

tomi-font · 2024-10-03T16:02:33Z

subsys/nrf_security/CMakeLists.txt

@@ -102,8 +102,29 @@ endif()

 set(CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG  True)

+if(CONFIG_PSA_SSF_CRYPTO_CLIENT AND NOT CONFIG_NRF_SECURITY)


So CONFIG_PSA_SSF_CRYPTO_CLIENT is independent from CONFIG_NRF_SECURITY but still using some of its CMake logic? I'm wondering if this can potentially cause some issues...

frkv

There are lots of complex additions in this PR that seem to be tailored towards a special case without PSA crypto which is the default enabled and default supported in nRF54H20 devices

Vge0rge · 2024-10-23T07:23:49Z

Closing this as this PR is doing the same functionality #17819

Vge0rge · 2024-10-24T08:19:28Z

Reopening to check something on CI

Make all PSA drivers depend on the OBERON_PSA_CORE since we cannot use the drivers without it. Signed-off-by: Georgios Vasilakis <[email protected]>

Brings Zephyr changes which automatically enable the PSA crypto as the entropy generator for Zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>

Add configuration to allow enabling the SSF PSA client when nrf_security is not enabled. This is particularly useful for the applications that only want to use the PSA rng and no other crypto. Enabling nrf_security in these applications will result to an increased application footprint and configuration complexity without any reason. This configuration provides the PSA implementation from the secure domain through the SSF client and it has no configurability yet. So there is no need to enforce NRF_SECURITY with this configuration. Signed-off-by: Georgios Vasilakis <[email protected]>

Add overlay to reduce the footprint of the matter_bridge application. Signed-off-by: Georgios Vasilakis <[email protected]>

Remove prng dts node since this is removed from the nrf54h20 board file. Signed-off-by: Georgios Vasilakis <[email protected]>

The changes to enable PSA RNG on 54H20 made sample.suit.smp_transfer.recovery overflow ROM on recovery_hci_ipc. Slightly increase the size of the cpurad_recovery_partition so that everything fits. Signed-off-by: Tomi Fontanilles <[email protected]>

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 5, 2024

NordicBuilder added manifest-zephyr DNM labels Sep 5, 2024

Vge0rge force-pushed the 54h20_psa_rng branch from 387c99f to 1a1154a Compare September 24, 2024 10:48

Vge0rge marked this pull request as ready for review September 24, 2024 10:48

Vge0rge requested review from a team as code owners September 24, 2024 10:48

Vge0rge force-pushed the 54h20_psa_rng branch 7 times, most recently from 114059e to 6ed58b2 Compare September 27, 2024 12:24

Vge0rge requested a review from a team as a code owner October 1, 2024 07:43

endre-nordic approved these changes Oct 1, 2024

View reviewed changes

Vge0rge force-pushed the 54h20_psa_rng branch from be24ea7 to 8ad341c Compare October 1, 2024 11:20

Vge0rge requested a review from a team as a code owner October 1, 2024 12:40

tomi-font requested changes Oct 3, 2024

View reviewed changes

endre-nordic added this to the 2.8.0 milestone Oct 18, 2024

frkv self-requested a review October 18, 2024 08:08

frkv requested changes Oct 18, 2024

View reviewed changes

Vge0rge force-pushed the 54h20_psa_rng branch 4 times, most recently from b8fb7cd to 7e9300c Compare October 21, 2024 10:32

Vge0rge force-pushed the 54h20_psa_rng branch from 7e9300c to fd61505 Compare October 21, 2024 17:22

Vge0rge requested a review from a team as a code owner October 21, 2024 17:22

Vge0rge closed this Oct 23, 2024

Vge0rge removed this from the 2.8.0 milestone Oct 24, 2024

Vge0rge reopened this Oct 24, 2024

Vge0rge force-pushed the 54h20_psa_rng branch from fd61505 to d33b7c8 Compare October 24, 2024 08:26

Vge0rge changed the title ~~entropy: Add PSA rng as the entropy provider for the nrf54h20~~ [DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 Oct 24, 2024

Vge0rge force-pushed the 54h20_psa_rng branch from d33b7c8 to eb14d1d Compare October 24, 2024 11:35

tomi-font requested review from tomi-font and removed request for tomi-font October 24, 2024 11:38

Vge0rge force-pushed the 54h20_psa_rng branch from eb14d1d to 17f9529 Compare October 30, 2024 08:39

tomi-font force-pushed the 54h20_psa_rng branch from 17f9529 to f3d408d Compare October 31, 2024 09:06

Vge0rge and others added 6 commits November 1, 2024 10:14

nrf_security: Make PSA drivers depend on PSA core

96d4709

Make all PSA drivers depend on the OBERON_PSA_CORE since we cannot use the drivers without it. Signed-off-by: Georgios Vasilakis <[email protected]>

manifest: Bring Zephyr with PSA RNG for NRF54H20

4051ac9

Brings Zephyr changes which automatically enable the PSA crypto as the entropy generator for Zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>

application: matter_bridge: Add overlay for 54h20

137ba4b

Add overlay to reduce the footprint of the matter_bridge application. Signed-off-by: Georgios Vasilakis <[email protected]>

samples: suit: flash_compantion: Remove prng

f08c004

Remove prng dts node since this is removed from the nrf54h20 board file. Signed-off-by: Georgios Vasilakis <[email protected]>

tomi-font force-pushed the 54h20_psa_rng branch from 69e6f05 to 1a81cac Compare November 1, 2024 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200

[DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200

Vge0rge commented Sep 5, 2024

NordicBuilder commented Sep 5, 2024 •

edited

Loading

NordicBuilder commented Sep 5, 2024 •

edited

Loading

NordicBuilder commented Sep 24, 2024

tomi-font left a comment

tomi-font Oct 3, 2024

tomi-font Oct 3, 2024

frkv left a comment

Vge0rge commented Oct 23, 2024

Vge0rge commented Oct 24, 2024

		@@ -102,8 +102,29 @@ endif()

		set(CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG True)

		if(CONFIG_PSA_SSF_CRYPTO_CLIENT AND NOT CONFIG_NRF_SECURITY)

[DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200

Are you sure you want to change the base?

[DONT REVIEW]entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200

Conversation

Vge0rge commented Sep 5, 2024

NordicBuilder commented Sep 5, 2024 • edited Loading

NordicBuilder commented Sep 5, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Sep 24, 2024

tomi-font left a comment

Choose a reason for hiding this comment

tomi-font Oct 3, 2024

Choose a reason for hiding this comment

tomi-font Oct 3, 2024

Choose a reason for hiding this comment

frkv left a comment

Choose a reason for hiding this comment

Vge0rge commented Oct 23, 2024

Vge0rge commented Oct 24, 2024

NordicBuilder commented Sep 5, 2024 •

edited

Loading

NordicBuilder commented Sep 5, 2024 •

edited

Loading