storage: bm_storage: use errno instead of nrf_error #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog-entry-required
|
You can find the documentation preview for this PR here. |
b-gent
approved these changes
Oct 30, 2025
eivindj-nordic
force-pushed
the
error_code_alignment_storage
branch
3 times, most recently
from
4e7be0e to
bcee21f
Compare
eivindj-nordic
force-pushed
the
error_code_alignment_storage
branch
from
bcee21f to
594ff03
Compare
anhmolt
reviewed
Nov 4, 2025
eivindj-nordic
force-pushed
the
error_code_alignment_storage
branch
from
594ff03 to
dc0ef45
Compare
hermabe
reviewed
Nov 5, 2025
There was a problem hiding this comment.
What is this file? Looks like it was generated by nrfutil? It does probably not belong here and will be overwritten on next SoftDevice export.
There was a problem hiding this comment.
Correct, it should not be here. @nordicjm Should this be added to .gitignore or can it be rendered in the build folder or so instead?
eivindj-nordic
force-pushed
the
error_code_alignment_storage
branch
from
dc0ef45 to
7783e7f
Compare
MirkoCovizzi
reviewed
Nov 5, 2025
|
|
||
| * Updated to use errno instead of nrf_errors. | ||
|
|
||
|
|
include/bm/storage/bm_storage.h
Outdated
| * 0 on success. | ||
| * A negative errno otherwise. | ||
| */ | ||
| uint32_t result; |
| * @retval 0 on success. | ||
| * @retval -EFAULT If @p storage is @c NULL. | ||
| * @retval -EBUSY If the implementation-specific resource is busy. | ||
| * @retval -EIO If an implementation-specific internal error occurred. |
There was a problem hiding this comment.
I would use EFAULT for generic failures. IO is more for read/write and such.
There was a problem hiding this comment.
We use EFAULT for NULL checks.
| * @retval NRF_ERROR_BUSY If the implementation-specific resource is busy. | ||
| * @retval NRF_ERROR_INTERNAL If an implementation-specific internal error occurred. | ||
| * @retval 0 on success. | ||
| * @retval -EFAULT If @p storage is @c NULL. |
There was a problem hiding this comment.
EINVAL? I prefer to use EINVAL here, but I know that we don't really have a standard for this.
There was a problem hiding this comment.
This is the standard in the repo.
Fix compliance issue. Signed-off-by: Eivind Jølsgard <[email protected]>
Use errnos for BM storage as it is not a BLE library or BLE subsystem. Correct return values for BM ZMS. Signed-off-by: Eivind Jølsgard <[email protected]>
ring_buf_get() returns the size retrieved and will never be negative. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
error_code_alignment_storage
branch
from
7783e7f to
cd7a854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use errnos for BM storage as it is not a BLE library or BLE subsystem.