Update embedded-io requirement from 0.6.1 to 0.7.1 in /nrf-hal-common #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [embedded-io](https://github.com/rust-embedded/embedded-hal) to permit the latest version. - [Release notes](https://github.com/rust-embedded/embedded-hal/releases) - [Commits](rust-embedded/embedded-hal@embedded-io-v0.6.1...embedded-io-v0.7.1) --- updated-dependencies: - dependency-name: embedded-io dependency-version: 0.7.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Fixed the new dependency on |
qwandor
reviewed
Oct 2, 2025
| } | ||
| } | ||
|
|
||
| impl core::error::Error for Error {} |
There was a problem hiding this comment.
Optional, but we could consider using thiserror to derive these implementations.
There was a problem hiding this comment.
Thought about it, but decided the dependency wasn't worth it. Would be interested in any counterpoint!
nrf-hal-common/src/uarte.rs
Outdated
| } | ||
|
|
||
| impl core::fmt::Display for Error { | ||
| fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { |
There was a problem hiding this comment.
Nit: Add use statements for Display and Formatter rather than full paths here.
There was a problem hiding this comment.
Replaced core::fmt with fmt since that's what we're doing elsewhere in this file already. Hope that's OK.
BartMassey
force-pushed
the
dependabot/cargo/nrf-hal-common/embedded-io-0.7.1
branch
from
7e4810c to
4739060
Compare
BartMassey
force-pushed
the
dependabot/cargo/nrf-hal-common/embedded-io-0.7.1
branch
from
4739060 to
9fbed1e
Compare
|
Thanks much for the careful review. Hope this is OK now. |
qwandor
approved these changes
Oct 3, 2025
BartMassey
deleted the
dependabot/cargo/nrf-hal-common/embedded-io-0.7.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on embedded-io to permit the latest version.
Commits
21e547aMerge pull request #708 from Dirbaio/release-0.7.1ed3297eRelease embedded-io 0.7.14949c74io: removeRead/Writesupertrait forReadReady/WriteReady.a926c2aMerge pull request #679 from chrysn-pull-requests/embedded-io-079123afbRelease embedded-io{,*} 0.7cb4f7a4Merge pull request #697 from hermit-os/io-vec_deque8c2b548Merge pull request #696 from hermit-os/async-write-flushd75daf9feat(async-io): make asyncWrite::flusha required methodc5a45aeMerge pull request #706 from ColinFinck/patch-13332728Update embedded-io README for defmt feature and MSRVDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)