Skip to content

feat: extend possibly unnecessary patterns - #3162

Open
btea wants to merge 2 commits into
npmx-dev:mainfrom
btea:feat/add-more-patterns
Open

feat: extend possibly unnecessary patterns#3162
btea wants to merge 2 commits into
npmx-dev:mainfrom
btea:feat/add-more-patterns

Conversation

@btea

@btea btea commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

/

🧭 Context

Add test-related configuration files to POSSIBLY_UNNECESSARY_PATTERNS.

📚 Description

@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview Aug 9, 2026 3:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Aug 9, 2026 3:02pm
npmx-lunaria Ignored Ignored Aug 9, 2026 3:02pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e37e1c7b-add6-4f23-b61d-341fb9ae92ff

📥 Commits

Reviewing files that changed from the base of the PR and between 6ed916c and eff29bd.

📒 Files selected for processing (1)
  • test/unit/app/utils/package-content-hints.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved package content checks to flag potentially unnecessary Playwright and Vitest JavaScript or TypeScript configuration files.

Walkthrough

The package content hint list now includes Playwright and Vitest configuration filenames with JavaScript and TypeScript extensions. Unit tests cover supported and unsupported extensions.

Changes

Package content hints

Layer / File(s) Summary
Configuration filename patterns
app/utils/package-content-hints.ts, test/unit/app/utils/package-content-hints.spec.ts
Adds patterns for playwright.config.* and vitest.config.* files with JavaScript and TypeScript extensions. Tests verify that JSON and TXT variants are not flagged.

Possibly related PRs

Suggested reviewers: gameroman

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the addition of patterns for possibly unnecessary test configuration files.
Description check ✅ Passed The description states that test-related configuration files are added to POSSIBLY_UNNECESSARY_PATTERNS.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for those in package-content-hints.spec.ts please

@btea

btea commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Could you add tests for those in package-content-hints.spec.ts please

Done 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants