feat: add nodejs noodle#2778
Open
alexdln wants to merge 4 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughReplaces the Press noodle with a Node.js noodle: adds ChangesNoodle logo replacement
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Noodle/Nodejs/Logo.vue`:
- Around line 9-12: The external anchor element in Logo.vue that sets
target="_blank" for the Node.js release link (the <a ...
href="https://github.com/nodejs/node-v0.x-archive/releases/tag/v0.0.1"
target="_blank"> anchor) should include rel="noopener noreferrer" to prevent
reverse-tabnabbing; update that anchor element to add rel="noopener noreferrer"
alongside the existing attributes (keeping class="underline" and href intact).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 085ae28a-6d74-4507-ab71-880d1ce386fe
📒 Files selected for processing (4)
app/components/Noodle/Nodejs/Logo.vueapp/components/Noodle/Press/Logo.vueapp/components/Noodle/index.tstest/nuxt/a11y.spec.ts
💤 Files with no reviewable changes (1)
- app/components/Noodle/Press/Logo.vue
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Tooltip/App.vue`:
- Line 43: Currently attrs is built by spreading consumer props.tooltipAttr
after setting role and id, allowing consumers to override component-owned
accessibility attributes (role and id) and break aria-describedby linkage;
change construction so component-owned attributes (role: 'tooltip' and id:
tooltipId) are applied last or otherwise take precedence over props.tooltipAttr
(e.g., merge as {...props.tooltipAttr, role: 'tooltip', id: tooltipId} or assign
role/id after spreading) so that attrs, tooltipId, and role remain authoritative
and cannot be overridden by props.tooltipAttr.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b55f916c-ad4c-4b67-a8a9-f14a3a593804
📒 Files selected for processing (2)
app/components/Noodle/Nodejs/Logo.vueapp/components/Tooltip/App.vue
graphieros
reviewed
May 22, 2026
| /** Offset distance in pixels (default: 4) */ | ||
| offset?: number | ||
| /** Additional attributes to be applied to the tooltip element */ | ||
| tooltipAttr?: Record<string, unknown> |
Contributor
There was a problem hiding this comment.
I think you can replace this prop by using Vue's attrs inheritance system:
defineOptions({
inheritAttrs: false,
})
const attrs = useAttrs()
// Then
const tooltipAttrs = computed(() => {
const mergedAttrs: Record<string, unknown> = {
role: 'tooltip',
id: tooltipId,
...attrs,
}
if (props.interactive) {
mergedAttrs.onMouseenter = show
mergedAttrs.onMouseleave = hide
}
return mergedAttrs
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 Context
New noodle 🍜