Skip to content

Conversation

@wraithgar
Copy link
Member

This includes a breaking change bumping engines.

@wraithgar wraithgar requested a review from a team as a code owner October 21, 2025 04:24
@cjihrig
Copy link

cjihrig commented Oct 21, 2025

Just as an FYI, there is no glob support in Node v20. It has caused a lot of headaches, but the core team has refused to backport globbing.

@wraithgar
Copy link
Member Author

wraithgar commented Oct 21, 2025

Just as an FYI, there is no glob support in Node v20. It has caused a lot of headaches, but the core team has refused to backport globbing.

Do you mean the globbing in node --test foo/**/*.js?

ETA: yep looks like that's what you're referring to

 > [email protected] test
> node --test './test/**/*.js'

Could not find '/home/runner/work/ini/ini/test/**/*.js'

@wraithgar
Copy link
Member Author

Still need to also investigate why the 22.x tests are failing in mac and linux.

@cjihrig
Copy link

cjihrig commented Oct 21, 2025

Correct, the test runner does not support globbing in v20. I know of at least one project, borp, that was created just to paper over a few differences across versions.

@wraithgar
Copy link
Member Author

For now we're gonna let the shell do the globbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants