Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npmpublish.yml #785

Closed
wants to merge 1 commit into from
Closed

npmpublish.yml #785

wants to merge 1 commit into from

Conversation

ericramos1980
Copy link

name: Node.js Package

on:
release:
types: [created]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
- run: npm ci
- run: npm test

publish-npm:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{8e8d00fe-5b2e-4c0f-8d0f-fc5a8c15e40c}}

publish-gpr:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: https://npm.pkg.github.com/
scope: '@ericramos1980
- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ 1e4d0db522cd0685f244c977f102905ce0c871a9}}

What / Why

n/a

References

  • n/a

name: Node.js Package

on:
  release:
    types: [created]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v1
        with:
          node-version: 12
      - run: npm ci
      - run: npm test

  publish-npm:
    needs: build
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v1
        with:
          node-version: 12
          registry-url: https://registry.npmjs.org/
      - run: npm ci
      - run: npm publish
        env:
          NODE_AUTH_TOKEN: ${{8e8d00fe-5b2e-4c0f-8d0f-fc5a8c15e40c}}

  publish-gpr:
    needs: build
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v1
        with:
          node-version: 12
          registry-url: https://npm.pkg.github.com/
          scope: '@ericramos1980
      - run: npm ci
      - run: npm publish
        env:
          NODE_AUTH_TOKEN: ${{ 1e4d0db522cd0685f244c977f102905ce0c871a9}}
@ericramos1980 ericramos1980 requested a review from a team as a code owner February 8, 2020 11:35
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you trying to get the npm cli published under your personal scope?

- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{8e8d00fe-5b2e-4c0f-8d0f-fc5a8c15e40c}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this token is now compromised; you may want to rotate it.

- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ 1e4d0db522cd0685f244c977f102905ce0c871a9}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too

node-version: 12
registry-url: https://npm.pkg.github.com/
scope: '@ericramos1980
- run: npm ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have an extra apostrophe here.

@darcyclarke
Copy link
Contributor

I believe this PR was mistakenly open, unless there's something I'm missing here. To @ljharb's points, it looks like you're going to have to rotate those NPM auth tokens now that you've shared them here.

I'll be closing this PR now.

@darcyclarke darcyclarke closed this Feb 9, 2020
@armano2
Copy link

armano2 commented Feb 11, 2020

@darcyclarke it seems that this is a bot or his account got hacked, he opened alot of almost same PR across a lot of repositories, that includes git, npm, codecov, nginx, electron list go on

in some of them he is also is trying to change/replace licenses with his name or create some weird files

eg.
https://github.com/nginx/nginx/pull/49/files
#785
git/git#704
gitcoinco/web#5911
indutny/bn.js#240
ethjs/ethjs#35
kubernetes/website#16811

this list goes on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants