Early stopping #21
Open
Early stopping #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up early stopping code, but left it as a modification to the BaseASGD and NaiveASGD.
Rationale: I think early stopping of some description is always desired, and the old behavior can be obtained by setting min_observations = max_observations = n_iterations * N_POINTS.
If now or later someone says that this early stopping heuristic is can be improved, then I suggest just modifying the base class to use the other heuristic. I hesitate to use some elaborate plugin system to manage the early stopping heuristics because if someone wants that kind of control then they should use partial_fit directly. That said, I think a fit() with no stopping heuristic is basically not very useful.