Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for postgres-xl table distribution #1697
base: main
Are you sure you want to change the base?
Adding support for postgres-xl table distribution #1697
Changes from 9 commits
4d98cac
de42146
93f5ca2
a6a2332
0a6e96d
5c48e7c
e7c6f58
822d866
e523a95
e687815
ee87847
281a717
9c6f6a8
7d88298
fe5734b
cd5a15a
7be8749
4000c67
d76d3dd
016212f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preferred way to continue a column is via
Expression<Func<TEntity,object>>
, which allows a more fluent and strongly-typed approach. Take a look at how IncludeProperties is implemented on indexes.Another thing that's important, is that the metadata and builder API does not deal with columns - it deals with (conceptual) properties. This is important since the property can have a different name than the column it's mapped to. Once again, IncludeProperties should provide a similar scenario to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would an overload on these methods be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - we need overloads for both
Expression<Func<..>>
(for regular strongly-typed usage) and string (for weakly-typed usage), and also make sure the string parameter references the property, and not its column. Basically use IncludeProperties in NpgsqlIndexBuilderExtensions as your implementation model.