test: fix static analysis

noxasch · Dec 13, 2023 · ca6e8f5 · ca6e8f5
1 parent 747b955
commit ca6e8f5
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 33 deletions.
diff --git a/app_widget/README.md b/app_widget/README.md
@@ -465,25 +465,27 @@ void main() {
 
   const MethodChannel channel = MethodChannel(AppWidgetPlatform.channel);
   final List<MethodCall> log = <MethodCall>[];
-
-  channel.setMockMethodCallHandler((methodCall) async {
-      log.add(methodCall);
-      switch (methodCall.method) {
-        case 'configureWidget':
-          return true;
-        case 'cancelConfigureWidget':
-          return true;
-        case 'getWidgetIds':
-          return [42];
-        case 'reloadWidgets':
-          return true;
-        case 'updateWidget':
-          return true;
-        case 'widgetExist':
-          return true;
-        default:
-      }
-    });
+  
+
+  TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+      .setMockMethodCallHandler(channel, (methodCall) async {
+    log.add(methodCall);
+    switch (methodCall.method) {
+      case 'getPlatformVersion':
+        return '42';
+      case 'configureWidget':
+        return true;
+      case 'cancelConfigureWidget':
+        return true;
+      case 'getWidgetIds':
+        return [];
+      case 'reloadWidgets':
+        return true;
+      case 'widgetExist':
+        return true;
+      default:
+        return null;
+    }
   });
 
   setUp(() {

diff --git a/app_widget/test/app_widget_ios_test.dart b/app_widget/test/app_widget_ios_test.dart
@@ -11,8 +11,8 @@ void main() {
   final List<MethodCall> log = <MethodCall>[];
 
   setUpAll(() {
-    // ignore: always_specify_types
-    channel.setMockMethodCallHandler((methodCall) async {
+    TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+        .setMockMethodCallHandler(channel, (methodCall) async {
       log.add(methodCall);
       switch (methodCall.method) {
         case 'getPlatformVersion':
@@ -28,6 +28,7 @@ void main() {
         case 'widgetExist':
           return true;
         default:
+          return null;
       }
     });
   });

diff --git a/app_widget/test/app_widget_test.dart b/app_widget/test/app_widget_test.dart
@@ -13,8 +13,8 @@ void main() {
   final List<MethodCall> log = <MethodCall>[];
 
   setUpAll(() {
-    // ignore: always_specify_types
-    channel.setMockMethodCallHandler((methodCall) async {
+    TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+        .setMockMethodCallHandler(channel, (methodCall) async {
       log.add(methodCall);
       switch (methodCall.method) {
         case 'getPlatformVersion':
@@ -32,6 +32,7 @@ void main() {
         case 'widgetExist':
           return true;
         default:
+          return false;
       }
     });
   });
@@ -71,7 +72,7 @@ void main() {
             'payload': '{"itemId": 1, "stringUid": "uid"}',
             'url': 'https://google.come',
           },
-        )
+        ),
       ]);
     });
 
@@ -102,7 +103,7 @@ void main() {
             'payload': '{"itemId": 1, "stringUid": "uid"}',
             'url': 'https://google.come',
           },
-        )
+        ),
       ]);
     });
 
@@ -132,7 +133,7 @@ void main() {
             'payload': '{"itemId": 1, "stringUid": "uid"}',
             'url': 'https://google.come',
           },
-        )
+        ),
       ]);
     });
 
@@ -163,7 +164,7 @@ void main() {
             'payload': '{"itemId": 1, "stringUid": "uid"}',
             'url': 'https://google.come',
           },
-        )
+        ),
       ]);
     });
 
@@ -179,7 +180,7 @@ void main() {
         isMethodCall(
           'cancelConfigureWidget',
           arguments: null,
-        )
+        ),
       ]);
     });
 
@@ -200,7 +201,7 @@ void main() {
             'androidProviderName': 'TestProvider',
             'androidPackageName': 'appname',
           },
-        )
+        ),
       ]);
     });
 
@@ -222,7 +223,7 @@ void main() {
             'androidProviderName': 'TestProvider',
             'androidPackageName': 'appname2',
           },
-        )
+        ),
       ]);
     });
 
@@ -243,7 +244,7 @@ void main() {
             'androidProviderName': 'TestProvider',
             'androidPackageName': 'appname',
           },
-        )
+        ),
       ]);
     });
 
@@ -265,7 +266,7 @@ void main() {
             'androidProviderName': 'TestProvider',
             'androidPackageName': 'appname2',
           },
-        )
+        ),
       ]);
     });
 
@@ -283,7 +284,7 @@ void main() {
           arguments: <String, Object>{
             'widgetId': 12,
           },
-        )
+        ),
       ]);
     });
   });