feat(dashboard): signup and login page design update #7070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
commented
Nov 19, 2024
| return ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="28" height="28" viewBox="0 0 17 16" fill="none" {...props}> | ||
| <path | ||
| d="M6.50004 7.99999L7.83337 9.33333L10.5 6.66666M15.1667 7.99999C15.1667 11.6819 12.1819 14.6667 8.50004 14.6667C4.81814 14.6667 1.83337 11.6819 1.83337 7.99999C1.83337 4.3181 4.81814 1.33333 8.50004 1.33333C12.1819 1.33333 15.1667 4.3181 15.1667 7.99999Z" | ||
| stroke="#1FC16B" | ||
| stroke={props.color ?? '#1FC16B'} |
There was a problem hiding this comment.
Added the abilty to update the color from the default green
There was a problem hiding this comment.
Variant styles should be applied via Tailwind classes on the className prop only, not via new props. So you can simply pass something like: <CircleCheck className="stroke-accent" />, or replace accent with an override using stroke-[red] or whichever color is necessary.
There was a problem hiding this comment.
@rifont issue is that I need this to be applied to the specific path element which is a child of the SVG parent. Will check if I can somehow convert it to use nesting.
scopsy
commented
Nov 20, 2024
scopsy
commented
Nov 20, 2024
rifont
reviewed
Nov 20, 2024
rifont
reviewed
Nov 20, 2024
rifont
reviewed
Nov 20, 2024
rifont
reviewed
Nov 20, 2024
scopsy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer