feat(providers): Add possibility to Onesignal choose version api

[suplere]

What changed? Why was the change needed?

This PR add possibility to Onesignal provider choose between:
a) player model
b) user model

User model documentation

Expand for optional sections

Special notes for your reviewer

[netlify]

👷 Deploy request for novu-stg-vite-dashboard-poc pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ba73c49

[L-U-C-K-Y]

@suplere nice, you created a new one, I actually also just did, what do you think about my MR?
I like that you use the new API, I just changed the key with an override, a bit simpler: #6979

[L-U-C-K-Y]

@suplere I would vote for your version! I'll close mine after this is merged.
Thank you so much

@scopsy sorry for tagging you again, but is the better MR, would highly appreciate if we could get it merged to unblock our users

[Michael-JobDone]

👍

[suplere]

This solution use new API. This allows you to use the new and recommended Onesignal API. The old API (with player model) may be marked as obsolete or unsupported over time.

[L-U-C-K-Y]

This solution use new API. This allows you to use the new and recommended Onesignal API. The old API (with player model) may be marked as obsolete or unsupported over time.

Absolutely, I closed mine

[L-U-C-K-Y]

@suplere do we need to use CredentialsKeyEnum.Domain here as we use this.apiVersion = config.domain; in the provider?

[scopsy]

Yes, I have updated this to be apiVersion and passed the proper info from the handler

[scopsy]

@L-U-C-K-Y, do you know by chance if the API body signature is similar to both modes and API endpoints?

[scopsy]

I'm just wondering if we even need to change the BASE URL at all

[L-U-C-K-Y]

@scopsy yes that would still be required if we want to keep "include_player_ids" in the older model.
Your change looks all good for me 😄

v9
See here the API Documentation for v9 (old):
https://documentation.onesignal.com/v9.0/reference/create-notification

V9 does not have the key include_aliases (was named: include_external_user_ids and still had the concept of player ids and therefore had include_player_ids.

v11.6
And here 11.6 (new):
https://documentation.onesignal.com/reference/push-notification

V11.6 has include_aliases where we can send the external ids, but no include_player_ids.
In the new versions, player ids are not used anymore and the recommended way is the external id:

https://documentation.onesignal.com/docs/users

It is always recommended to use the External ID to identify users because this is the only way to track a user across all their subscriptions.

[suplere]

Hello, it is looks better than my version.

[L-U-C-K-Y]

Suggested change

	? {
	include_aliases: {
	external_id: options.target,
	},
	}
	? {
	include_aliases: {
	external_id: options.target,
	},
	target_channel: 'push',
	}

I just noticed in the docs that we would need to include the target_channel for the new API endpoint:

[suplere]

Yes this si good addition target channell pu#h

[L-U-C-K-Y]

Suggested change

	include_aliases: {
	external_id: ['userId'],
	},
	include_aliases: {
	external_id: ['userId'],
	},
	target_channel: 'push',

I just noticed in the docs that we would need to include the target_channel for the new API endpoint:

[suplere]

Is there some problem ?

[scopsy]

@suplere could you take a look on @L-U-C-K-Y suggestions?

[suplere]

This si good addition target channel push

[suplere]

Yes this si good addition target channell pu#h

[L-U-C-K-Y]

This si good addition target channel push

@suplere can you please make the changes? It's your MR. You can also just merge this one: suplere#1

Then we're all good!

[L-U-C-K-Y]

@scopsy changes are merged, LGTM! 😄