fix(js): Remove @novu/shared dependency #6906

SokratisVidros · 2024-11-08T17:22:55Z

What changed? Why was the change needed?

Clone HTTP client from @novu/client to remove all @novu/shared leakages in @novu/js

netlify · 2024-11-08T17:23:12Z

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name	Link
🔨 Latest commit	`b1ef2fb`
🔍 Latest deploy log	https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/674a31f23ba2750008309567
😎 Deploy Preview	https://deploy-preview-6906.dashboard-v2.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/js/src/novu.test.ts

pkg-pr-new · 2024-11-11T16:08:47Z

Open in Stackblitz

@novu/client

npm i https://pkg.pr.new/novuhq/novu/@novu/client@6906

@novu/framework

npm i https://pkg.pr.new/novuhq/novu/@novu/framework@6906

@novu/js

npm i https://pkg.pr.new/novuhq/novu/@novu/js@6906

@novu/nest

npm i https://pkg.pr.new/novuhq/novu/@novu/nest@6906

@novu/headless

npm i https://pkg.pr.new/novuhq/novu/@novu/headless@6906

@novu/nextjs

npm i https://pkg.pr.new/novuhq/novu/@novu/nextjs@6906

@novu/node

npm i https://pkg.pr.new/novuhq/novu/@novu/node@6906

@novu/notification-center

npm i https://pkg.pr.new/novuhq/novu/@novu/notification-center@6906

novu

npm i https://pkg.pr.new/novuhq/novu@6906

@novu/providers

npm i https://pkg.pr.new/novuhq/novu/@novu/providers@6906

@novu/react

npm i https://pkg.pr.new/novuhq/novu/@novu/react@6906

@novu/react-native

npm i https://pkg.pr.new/novuhq/novu/@novu/react-native@6906

@novu/shared

npm i https://pkg.pr.new/novuhq/novu/@novu/shared@6906

@novu/stateless

npm i https://pkg.pr.new/novuhq/novu/@novu/stateless@6906

commit: b94d38c

BiswaViraj · 2024-11-12T14:06:08Z

packages/js/src/novu.ts

@@ -32,7 +26,6 @@ export class Novu implements Pick<NovuEventEmitter, 'on'> {
  constructor(options: NovuOptions) {
    this.#inboxService = new InboxService({
      backendUrl: options.backendUrl ?? PRODUCTION_BACKEND_URL,
-      userAgent: options.__userAgent ?? userAgent,


This is needed for useragent analytics from @novu/react and other packages

Good catch. I will add it back.

jainpawan21 · 2024-11-26T18:33:22Z

@SokratisVidros

Is this PR ready to review?

netlify · 2024-11-29T21:02:11Z

✅ Deploy Preview for dev-web-novu ready!

Name	Link
🔨 Latest commit	`b94d38c`
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/674efed1619db50008099171
😎 Deploy Preview	https://deploy-preview-6906.dashboard.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-11-29T21:07:00Z

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name	Link
🔨 Latest commit	`b94d38c`
🔍 Latest deploy log	https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/674efed1a9a0360008080408
😎 Deploy Preview	https://deploy-preview-6906.dashboard-v2.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SokratisVidros · 2024-11-29T21:19:18Z

@SokratisVidros

Is this PR ready to review?

Yes it is now.

LetItRock · 2024-11-29T21:25:18Z

packages/js/src/novu.test.ts

  });

-  describe('lazy session initialization', () => {
-    test('should call the queued notifications.list after the session is initialized', async () => {
+  describe('http client', () => {


can you please add your tests separately? because the previous ones were covering lazy session initialization and queueing

LetItRock · 2024-11-29T21:25:49Z

packages/js/src/novu.test.ts

      expect(data).toEqual({
        notifications: mockNotificationsResponse.data,
        hasMore: mockNotificationsResponse.hasMore,
        filter: mockNotificationsResponse.filter,
      });
    });
-
-    test('should reject the queued notifications.list if session initialization fails', async () => {


why we removed these two?

I moved these tests to the BaseModule. Did I miss anything?

Well, I missed to push the new file 😮‍💨

- project: @novu/node 2.0.5

Clone HTTP client from @novu/client to remove all @novu/shared leakages in @novu/js

Note that the global monorepo eslint runs on each package.

This reverts commit 8a23520.

SokratisVidros requested review from LetItRock and rifont November 8, 2024 17:22

SokratisVidros temporarily deployed to Linting November 8, 2024 17:23 — with GitHub Actions Inactive

SokratisVidros requested a review from BiswaViraj November 8, 2024 17:23

github-advanced-security bot found potential problems Nov 8, 2024

View reviewed changes

packages/js/src/novu.test.ts Dismissed Show dismissed Hide dismissed

SokratisVidros force-pushed the remove_shared_from_js branch from 93da3ec to e8a6c4f Compare November 11, 2024 15:56

SokratisVidros temporarily deployed to Linting November 11, 2024 15:56 — with GitHub Actions Inactive

BiswaViraj reviewed Nov 12, 2024

View reviewed changes

SokratisVidros force-pushed the remove_shared_from_js branch from e8a6c4f to 64d796d Compare November 12, 2024 23:12

SokratisVidros temporarily deployed to Linting November 12, 2024 23:12 — with GitHub Actions Inactive

SokratisVidros force-pushed the remove_shared_from_js branch from 64d796d to 35c9d1f Compare November 29, 2024 20:54

SokratisVidros temporarily deployed to Linting November 29, 2024 20:54 — with GitHub Actions Inactive

SokratisVidros force-pushed the remove_shared_from_js branch from 35c9d1f to eb6a652 Compare November 29, 2024 21:16

SokratisVidros temporarily deployed to Linting November 29, 2024 21:16 — with GitHub Actions Inactive

SokratisVidros marked this pull request as ready for review November 29, 2024 21:17

LetItRock reviewed Nov 29, 2024

View reviewed changes

SokratisVidros temporarily deployed to Linting November 29, 2024 21:28 — with GitHub Actions Inactive

SokratisVidros added 4 commits December 3, 2024 14:35

chore(release): publish

77e3331

- project: @novu/node 2.0.5

fix(js): Remove @novu/shared dependency

6820020

Clone HTTP client from @novu/client to remove all @novu/shared leakages in @novu/js

fixup! fix(js): Remove @novu/shared dependency

e09e631

fix(js): Make Eslint happy.

b94d38c

Note that the global monorepo eslint runs on each package.

SokratisVidros force-pushed the remove_shared_from_js branch from b1ef2fb to b94d38c Compare December 3, 2024 12:51

SokratisVidros temporarily deployed to Linting December 3, 2024 12:51 — with GitHub Actions Inactive

github-actions bot added the @novu/api label Dec 3, 2024

BiswaViraj approved these changes Dec 3, 2024

View reviewed changes

LetItRock approved these changes Dec 3, 2024

View reviewed changes

SokratisVidros merged commit 8a23520 into next Dec 3, 2024
45 checks passed

SokratisVidros deleted the remove_shared_from_js branch December 3, 2024 15:08

scopsy added a commit that referenced this pull request Dec 3, 2024

Revert "fix(js): Remove @novu/shared dependency (#6906)"

f4a2de5

This reverts commit 8a23520.

scopsy mentioned this pull request Dec 3, 2024

Revert "fix(js): Remove @novu/shared dependency" #7206

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(js): Remove @novu/shared dependency #6906

fix(js): Remove @novu/shared dependency #6906

SokratisVidros commented Nov 8, 2024

netlify bot commented Nov 8, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 11, 2024 •

edited

Loading

BiswaViraj Nov 12, 2024

SokratisVidros Nov 12, 2024

jainpawan21 commented Nov 26, 2024 •

edited

Loading

netlify bot commented Nov 29, 2024 •

edited

Loading

netlify bot commented Nov 29, 2024 •

edited

Loading

SokratisVidros commented Nov 29, 2024

LetItRock Nov 29, 2024

LetItRock Nov 29, 2024

SokratisVidros Nov 29, 2024

SokratisVidros Nov 29, 2024 •

edited

Loading

fix(js): Remove @novu/shared dependency #6906

fix(js): Remove @novu/shared dependency #6906

Conversation

SokratisVidros commented Nov 8, 2024

What changed? Why was the change needed?

netlify bot commented Nov 8, 2024 • edited Loading

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

pkg-pr-new bot commented Nov 11, 2024 • edited Loading

BiswaViraj Nov 12, 2024

Choose a reason for hiding this comment

SokratisVidros Nov 12, 2024

Choose a reason for hiding this comment

jainpawan21 commented Nov 26, 2024 • edited Loading

netlify bot commented Nov 29, 2024 • edited Loading

✅ Deploy Preview for dev-web-novu ready!

netlify bot commented Nov 29, 2024 • edited Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

SokratisVidros commented Nov 29, 2024

LetItRock Nov 29, 2024

Choose a reason for hiding this comment

LetItRock Nov 29, 2024

Choose a reason for hiding this comment

SokratisVidros Nov 29, 2024

Choose a reason for hiding this comment

SokratisVidros Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

netlify bot commented Nov 8, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 11, 2024 •

edited

Loading

jainpawan21 commented Nov 26, 2024 •

edited

Loading

netlify bot commented Nov 29, 2024 •

edited

Loading

netlify bot commented Nov 29, 2024 •

edited

Loading

SokratisVidros Nov 29, 2024 •

edited

Loading