feat(api): add priority to queue based from 0.24.x (ref: PR 6489) #6528
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
approved these changes
Sep 19, 2024
rifont
requested changes
Sep 20, 2024
apps/api/src/app/events/usecases/parse-event-request/parse-event-request.command.ts
Show resolved
Hide resolved
SokratisVidros
approved these changes
Oct 2, 2024
rifont
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
We will accept the PR in the current state, but note that the Community Edition won't have the new priority property available in the OpenAPI specification until we conditionally expose the property via a custom decorator that operates on the IS_DOCKER_HOSTED environment variable flag.
We will raise a ticket to address this conditionality for the Community Edition in a separate follow-up ticket.
rifont
reviewed
Oct 29, 2024
Comment on lines
8
to
+11
| } from '@novu/shared'; | ||
|
|
||
| import { EnvironmentWithUserCommand } from '../../../shared/commands/project.command'; | ||
| import { ApiHideProperty } from '@nestjs/swagger'; |
There was a problem hiding this comment.
Needed to resolve the import order linting problem here.
Suggested change
| } from '@novu/shared'; | |
| import { EnvironmentWithUserCommand } from '../../../shared/commands/project.command'; | |
| import { ApiHideProperty } from '@nestjs/swagger'; | |
| } from '@novu/shared'; | |
| import { ApiHideProperty } from '@nestjs/swagger'; | |
| import { EnvironmentWithUserCommand } from '../../../shared/commands/project.command'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #6489