339 eslint production build #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we still need to check eslint somewhere in this process though. so I'm creating the build-test-lint workflow. ref: https://nextjs.org/docs/pages/api-reference/next-config-js/eslint
this commit change means we no longer get the error: "Detected next.config.js, no exported configuration found. https://nextjs.org/docs/messages/empty-configuration"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ref: https://nextjs.org/docs/app/building-your-application/testing/cypress#continuous-integration-ci ref: https://github.com/vercel/next.js/tree/canary/examples/with-cypress ref: https://github.com/cypress-io/github-action#end-to-end-testing ref: https://docs.cypress.io/guides/continuous-integration/github-actions
alishaevn
commented
Dec 16, 2023
| // Warning: This allows production builds to successfully complete even if | ||
| // your project has ESLint errors. | ||
| // ref: https://nextjs.org/docs/pages/api-reference/next-config-js/eslint | ||
| ignoreDuringBuilds: true, |
There was a problem hiding this comment.
I confirmed that this works by pushing this branch to production on vercel, while eslint still has a failure.
2 tasks
alishaevn
commented
Dec 16, 2023
Comment on lines
+38
to
+39
| // TODO(alishaevn): add these cookies to pages/legal-notices/cookie-policy.js under | ||
| // "Non-essential cookies" with a description and expiration time frame |
There was a problem hiding this comment.
split into 2 lines to appease lint rules
alishaevn
force-pushed
the
339-eslint-production-build
branch
from
704fa2e to
90ede7c
Compare
the existing line failed with a "Error: Cannot find module '/home/node/app/bash'" error. Locally and in CI/CD. I found a SO post and tried the suggestion, which worked locally. I'm hoping it will work in CI/CD too. ref: https://stackoverflow.com/a/49647309/8079848
trying to get around the error: > Cypress could not verify that this server is running: > http://localhost:3000 > We are verifying this server because it has been configured as your > baseUrl.
alishaevn
commented
Dec 18, 2023
Comment on lines
+25
to
+34
| cypress: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Cypress e2e | ||
| uses: cypress-io/github-action@v6 | ||
| with: | ||
| start: yarn start | ||
| wait-on: 'http://localhost:3000' |
There was a problem hiding this comment.
alishaevn
commented
Dec 18, 2023
Comment on lines
+35
to
+39
| eslint: | ||
| needs: build | ||
| uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
| with: | ||
| lint_cmd: docker compose run web sh -c 'yarn && yarn lint' |
There was a problem hiding this comment.
ref: https://github.com/scientist-softserv/viva/blob/main/.github/workflows/build-test-lint.yaml#L36-L40
I had to edit the lint_cmd slightly because I kept getting an error about not being able to find "bash".
alishaevn
commented
Dec 18, 2023
Comment on lines
+1
to
+24
| name: 'Build Test Lint' | ||
| run-name: Build Test Lint of ${{ github.ref_name }} by @${{ github.actor }} | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
| inputs: | ||
| debug_enabled: | ||
| type: boolean | ||
| description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)' | ||
| required: false | ||
| default: false | ||
|
|
||
| jobs: | ||
| build: | ||
| uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
| secrets: inherit | ||
| with: | ||
| platforms: 'linux/amd64' | ||
| webTarget: web |
There was a problem hiding this comment.
this already existed in "build.yml". I just moved it here.
alishaevn
commented
Dec 18, 2023
Comment on lines
+27
to
+28
| # remove the line below to enable the job | ||
| if: false |
There was a problem hiding this comment.
using this conditional to skip the workflow instead of commenting out the file.
kirkkwang
approved these changes
Dec 18, 2023
This was
linked to
issues
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
prevent eslint errors from failing a production build
Expected Behavior After Changes
Screenshots / Video
ref: this comment