-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump image-spec to v1.1.0-rc.3 and oras-go to v2.1.0 #306
Conversation
Signed-off-by: Shiwei Zhang <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 74.39% 74.39%
=======================================
Files 23 23
Lines 2175 2175
=======================================
Hits 1618 1618
Misses 439 439
Partials 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning? |
Also, under "internal/" so external imports don't work yet. |
Agree with @sajayantony. This change is also supposed to be considered in Notation CLI. |
This is partially addressed by #308. We might need more discussions on the warning and it can be done in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #305
Closes #307