Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed sign with multiple plugin_config #24

Merged
merged 14 commits into from
Aug 4, 2023
Merged

fix: fixed sign with multiple plugin_config #24

merged 14 commits into from
Aug 4, 2023

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts
fixed plugin-config
0def4c3 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated sign action.yml
7f78795 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested review from duffney, shizhMSFT and a team as code owners August 1, 2023 09:43
shizhMSFT
shizhMSFT reviewed Aug 1, 2023
View reviewed changes
dist/lib/checksum.js Show resolved Hide resolved
src/sign.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Two-Hearts
update
1a18af1 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated license checker workflow
620f00c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
5e7dab4 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated plugin_config to JSON array string
09ac9ec 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
9029a82 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
9171ce3 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
dabc562 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
a6de1b8 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
clean up
37db268 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated per code review
73cb2d1 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Aug 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/sign.ts Outdated Show resolved Hide resolved
src/sign.ts Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
5208c23 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated per code review
c443075 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Aug 3, 2023
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 9b1ca53 into notaryproject:main Aug 4, 2023
2 checks passed
@Two-Hearts Two-Hearts deleted the fix branch August 4, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@duffney duffney Awaiting requested review from duffney duffney is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signing with multiple plugin_config
2 participants
@Two-Hearts @shizhMSFT