Add support for mouse buttons 4 & 5 #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-fl3
reviewed
Aug 7, 2024
Cargo.toml
Outdated
| @@ -20,6 +20,9 @@ categories = ["rendering::graphics-api"] | |||
| # disabled by default | |||
| log-impl = [] | |||
|
|
|||
| [dependencies] | |||
| num_enum = "0.7.3" | |||
There was a problem hiding this comment.
num_enum adds full rust parser and a bunch of other dependencies into the build try. I would rather manually implement TryFrom for one enum we need it for.
There was a problem hiding this comment.
Okay, I used a conversion function instead to convert u8 to MouseButton type. Is this better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add support for mouse buttons 4 & 5 to macroquad.