Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color breakpoint markers and editor lightbulbs #182

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tapeinosyne
Copy link

Description

This patch assigns Nord colors to seven additional elements of the VS Code editor interface; specifically, it covers the otherwise jarring gutter and inline icons of breakpoints and autofix lightbulbs.

A few notes:

  • I kept contrast fairly low for lightbulbs, because they appear often enough to be intrusive otherwise. However, we might want to pick brighter colors as defaults. Perhaps nord9 and nord8? (End users can always override these settings, even on a theme-by-theme basis.)
  • The contrast of inactive breakpoints has been increased because they are points of interest, and should remain easy to spot.
  • The inline marker breakpointUnverified has the awkward requirements to be noticeable but unobtrusive while surrounded by syntax–highlighted tokens. Moreover, VS Code seems to apply some kind of darkening filter to the element, which is shifted from #81a1c1 to #68809a. We can either accept the change or remedy it by picking a brighter color.
element default nord
breakpoint (active) breakpoint, default breakpoint
breakpoint (inactive) breakpointDisabled, default breakpointDisabled
breakpoint (unverified) breakpointUnverified, default breakpointUnverified
breakpoint, active stackframe breakpointCurrentStackframe, default breakpointCurrentStackframe
breakpoint, other stackframe breakpointStackframe, default breakpointStackframe
lightbulb lightbulb, default lightbulb
lightbulb (autofix) ligthbulbAutofix, default lightbulbAutofix

References

Nord Colors and Palettes

@tapeinosyne tapeinosyne changed the title Color more elements Color breakpoint markers and editor lightbulbs Sep 30, 2020
@arcticicestudio
Copy link
Contributor

Hi @tapeinosyne 👋, thanks for your contribution 👍

Great catch, these are some small elements, but details that matter 😄
I'll try to review the changes in the near future to get this into the next release version.

@svengreb svengreb removed the request for review from arcticicestudio August 9, 2023 08:49
@svengreb
Copy link
Member

svengreb commented Aug 9, 2023

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@tapeinosyne Thanks (again) for your contribution 🚀
The pull request has been added to the queue and the review will be scheduled for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: queued
Development

Successfully merging this pull request may close these issues.

3 participants