Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Elixir syntax highlight for modules and atoms #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feliperenan
Copy link

@feliperenan feliperenan commented Dec 1, 2019

Related to: nordtheme/visual-studio-code#165

Before it was like this:

Screenshot from 2019-12-01 19-02-28

After this change:

Screenshot from 2019-12-01 19-03-13

@arcticicestudio
Copy link
Contributor

Hi @feliperenan 👋, thanks for your contribution 👍
I'll review it in the near future and get back to you.

jvoisin
jvoisin previously approved these changes Apr 19, 2022
@svengreb svengreb changed the base branch from develop to master May 14, 2022 12:48
@svengreb svengreb dismissed jvoisin’s stale review May 14, 2022 12:48

The base branch was changed.

@svengreb
Copy link
Member

svengreb commented Aug 18, 2022

Thanks for your patience @feliperenan, I think that the “near future“ is no longer an appropriate term, but unfortunately the maintenance and organization (overhead) tasks of the whole Nord project go to the cost of individual issues and PRs that are missed in the large amount of notifications.

Anyway, I tried to reproduce the highlighting, but it looks like that Vim is not shipped with Elixir syntax highlighting by default. At least I get no highlighting at all with the recent version 9.0.0200 and there is no syntax highlighting group detected when specifying and token like the defmodule keyword. Did you use a (third-party) plugin and added the groups accordingly, and if so, was it elixir-editors/vim-elixir?
When Vim does not bundle Elixir syntax highlighting by default any longer we can add support for the mentioned plugin of course.

@feliperenan
Copy link
Author

Hi @svengreb

yes, I was vim-elixir plugin for back when I did this patch. Now I don't anymore - I'm using treesiter from neovim and not sure how that plays along. Also, I'm not using this theme anymore so not sure if this fixes is still relevant.

With that being said, feel free to either close or accept this patch.

Thanks

@svengreb
Copy link
Member

@feliperenan Thank (again!) you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@feliperenan Thanks again for your contribution 🚀
The pull request has been added to the queue and the review will be planned for the next iterations!
Adding support for Neovim will be handled through a dedicated Nord port to tree-sitter will be supported too as soon as this port is available. Of course this "Vanilla" Vim port will be continued and support for the vim-elixir plugin will be started with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: queued
Development

Successfully merging this pull request may close these issues.

4 participants