Skip to content

0.11.0

Compare
Choose a tag to compare
@arcticicestudio arcticicestudio released this 15 Feb 19:23
v0.11.0

Release Date: 2020-02-15 Project Board Milestone

This version focused on fixing "random highlighting breakages" partially caused by changed in version 0.10.0, but also includes support for new editor scheme keys.

Features

Support new selected and inactive tab highlighting editor scheme keys#126#130 (⊶ a70716e) by @Tom1206 (reported in #120)
↠ Selected and inactive tabs were previously styled using the corresponding ui.EditorTabs.* UI theme keys. Some of these keys are now deprecated or marked as „unknown” to the UI theme scheme validator. The highlighting is now controlled using the new TAB_SELECTED and TAB_SELECTED_INACTIVE editor color scheme keys added to the IDE platform core code in JetBrains/intellij-community@bf26eb8e.

Even through this might indicate some inconsistency between the UI theme API and editor color scheme API, both new editor scheme keys have been added using the same colors like the UI theme keys in order to style tabs correctly again.

Before

After

Support background color styling of "diff" UI separator#128#132 (⊶ 5116bb8) by @Tom1206 (reported in #120)

The "diff" UI renders a line to separate the different sections of a patch/diff that was added to the IDE platform core code in jetbrains/intellij-community@f8de2a58.
In order to style the elements the DIFF_SEPARATORS_BACKGROUND editor scheme key has been added using nord3 as background color.

Before

After

Support highlighting of line number on caret row#122#133 (⊶ 074e0e8)
↠ Previously the line number on the current caret row was highlighted with the same color (nord3) like all other line numbers. This has been changed to use nord4 instead for lines with active caret(s) by adding support for the LINE_NUMBER_ON_CARET_ROW_COLOR editor scheme key that was added to the IDE platform core code in jetbrains/intellij-community@8641fedd.

Before

After

Support highlighting of selected indent guide#123#134 (⊶ 6879a65)
↠ Previously the selected indent guide was not highlighted differently like non-selected guides (nord3). This has been changed to use the same color like comments (nord3 with increased brightness) instead by adding support for the SELECTED_INDENT_GUIDE editor scheme key that was added to the IDE platform core code in jetbrains/intellij-community@7e3a238c.

Before

After

Support highlighting of selected indent guide#124#135 (⊶ 44ee42e)
↠ Previously only the INDENT_GUIDE editor scheme key was supported and defined, but not the VISUAL_INDENT_GUIDE key that was added to the IDE platform core code in jetbrains/intellij-community@2a178666.
Since both UI elements are almost the same, the new key also uses nord3 as foreground color.

Support new editor scheme key for runtime errors#127#131 (related to #120) (⊶ 7e21b74)
↠ In jetbrains/intellij-community@6fb72d02, the new RUNTIME_ERROR editor scheme key was added to the IDE platform core code to highlight runtime errors.
The new key has been added using nord11 as foreground color.

Before

After

Support highlighting of separator lines between editor and breadcrumbs#125#136 (⊶ 3428e87)
↠ Previously the SEPARATOR_ABOVE_COLOR and SEPARATOR_BELOW_COLOR editor scheme keys, which were added to the IDE platform code in jetbrains/intellij-community@dda11912, were not defined explicitly which made them inherit color values from other keys. They have been defined explicitly using nord3 as foreground color to ensure style consistency across IDE version updates.

Improvements

Replaced all color inheritances with explicit definitions#121 (related to #69, #70, #77, #78, #108, #109, #115, #117, #119, #120) (⊶ 2d8b341)
↠ Implemented a workaround documented in #120 to prevent more "random" color style breakages by replacing all editor color scheme keys that inherited values from other keys with the explicit style definitions instead.
This caused the code size of the editor scheme to increase drastically due to repeated styles, but is currently the only way to work around non-working style inheritance in the IDE theme API.

Bug Fixes

Restored removed parent_scheme attribute#120, #129, #119#137 (⊶ b74dc7e)
↠ In #117, the parent_scheme attribute was removed since it was suspected that it caused „random highlighting breakages” that are documented in detail in #120.

Anyway, contrary to the presumption that the attribute is not required, it caused syntax elements of many different languages to ignore some colors defined by the Nord plugin, like e.g. markup elements in (documentation) comments, strings in PHP (#119), data flow control characters like braces in TypeScript/JavaScript and even UI elements like tabs. See feedback comments of @Tom1206 and @yuru7 in #120 for more examples.
The „hardcoded“ color #808080 was used for all these elements instead that is used in different places in the IDE core platform code. It was not possible to fix these elements using the available editor scheme keys.

By simply adding back the parent_scheme attribute with the Darcula value all these elements now "magically" using the colors defined by Nord again instead of #808080. It is a strange behavior that this attribute is required for almost no reason, but it has been added back again to fix the massive style problems occurred as of Nord plugin version 0.10.0 in combination with the latest IDE versions 2019.3.3 (that was released on the same day like the plugin update…).

Data Flow Controls

Before

After

Markup Elements

Before

After

JSON

Before

After


The full changelog ist available here.