Use display-color-cells to enable 24-bit color terminal support
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
force-pushed
the
pr/gh-64-gh-59-24-bit-term-color-support
branch
from
d7b30d7 to
3c4e797
Compare
svengreb
approved these changes
Jan 5, 2020
arcticicestudio
added a commit
that referenced
this pull request
Jan 8, 2020
In order to fix "unable to load color x" errors when running Emacs in daemon-mode, the defined theme colors are now tested against the `display-color-cells` "display feature testing" function [1] to support 24-bit color terminals with a fallback to the `display-graphic-p` function. This is a first step to fix the problems described in GH-59. Related to GH-59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #64 originally contributed by @visigoth
Related to #59
Since #64 has not been submitted from a feature branch but the default develop` branch, this PR supersedes it in order to resolve the merge conflicts and pending code review comments.
@visigoth in #64: