split build workflow into two #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one that builds the preview one that build production once we merge or push to main for me this is easier to understand with fewer of the ifs but downside is a bit more duplication
|
Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/previews/PR465/ |
|
This looks good to me and I would merge. When using this, I think it wouldn't delete the previews when PRs get merged. There was another action on prs closed to do that (in the refs we saw). With that, I'd say go for this. |
|
Yes, another workflow does the cleanup. |
|
Oops - some run failed. I am looking into it. |
|
Followed-up in #466. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for me this is easier to understand with fewer of the ifs but downside is a bit more duplication