-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Matrix.User #19
Conversation
As a general rule of thumb, internal values need no opaque types to hide their implementation
Specifically on Hashdict/Mashdict as they variate based on JSON input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked through the code and it looks great to me. The documentation also renders nicely.
One idea for the future, however, is to be a bit more strict on combining the strings in the Text
module.
Similarly, the Given how there's issues like matrix-org/matrix-spec#1506 floating around the Matrix ecosystem, it might benefit debugging if the module was more helpful on how certain strings like user IDs do not meet the requirements of the Matrix spec. |
This pull request adds the
Matrix.User
module to be used by the developer.Additionally, it adds a breaking change where the
sender
field of the publicEvent
type is now aUser
type rather than asender
, effectively pushing for a major change.