Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 适配器和驱动器添加版本号和时间 #326

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

he0119
Copy link
Member

@he0119 he0119 commented Dec 16, 2024

顺便整理了一下 httpx 请求的 mock 值。

@github-actions github-actions bot added the enhancement New feature or request label Dec 16, 2024
@he0119 he0119 marked this pull request as draft December 16, 2024 15:25
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (9a1cbac) to head (3c9a516).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   92.77%   93.14%   +0.37%     
==========================================
  Files          41       41              
  Lines        2201     2262      +61     
==========================================
+ Hits         2042     2107      +65     
+ Misses        159      155       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@he0119 he0119 requested a review from BigOrangeQWQ December 17, 2024 01:39
@he0119 he0119 marked this pull request as ready for review December 17, 2024 01:39
@he0119 he0119 force-pushed the feat/adapter-driver-version branch from 5f91542 to 153cb95 Compare December 17, 2024 07:07
Copy link
Member

@BigOrangeQWQ BigOrangeQWQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 src/providers/models.py 文件有很大的优化空间,譬如 to_registry 函数。

测试没看

@he0119 he0119 merged commit 6e09ed0 into main Dec 17, 2024
7 checks passed
@he0119 he0119 deleted the feat/adapter-driver-version branch December 17, 2024 19:53
@he0119
Copy link
Member Author

he0119 commented Dec 17, 2024

感觉 src/providers/models.py 文件有很大的优化空间,譬如 to_registry 函数。

是的,所以我插件的 to_registry 都不想写了(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants