Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 插件测试中使用 uv 来控制 Python 版本并与本体共享依赖 #320

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

he0119
Copy link
Member

@he0119 he0119 commented Dec 8, 2024

nonetest 现在与 noneflow 共享依赖,并且使用 uv 来控制运行插件测试的 Python 版本。

这样就不需要多个版本的 nonetest,同时也不用限制 plugin_test 中使用的库。

@github-actions github-actions bot added the ci label Dec 8, 2024
@he0119 he0119 requested a review from BigOrangeQWQ December 8, 2024 08:20
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (67733ab) to head (3670acb).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/providers/docker_test/plugin_test.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   92.42%   92.77%   +0.35%     
==========================================
  Files          39       40       +1     
  Lines        2192     2202      +10     
==========================================
+ Hits         2026     2043      +17     
+ Misses        166      159       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@he0119 he0119 changed the title feat: 插件测试中使用 uv 来控制 Python 版本并于本体共享依赖 feat: 插件测试中使用 uv 来控制 Python 版本并与本体共享依赖 Dec 8, 2024
@he0119 he0119 force-pushed the build/docker-test branch from 6837a8f to 61377e6 Compare December 8, 2024 08:31
@he0119 he0119 force-pushed the build/docker-test branch from 4e59734 to e7f7feb Compare December 9, 2024 11:49
@he0119 he0119 added the enhancement New feature or request label Dec 9, 2024
Copy link
Member

@BigOrangeQWQ BigOrangeQWQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试我没细看,代码感觉逻辑没问题。

runner.py要不要改名成bot.py会不会更好一点?

@he0119
Copy link
Member Author

he0119 commented Dec 11, 2024

测试我没细看,代码感觉逻辑没问题。

runner.py要不要改名成bot.py会不会更好一点?

可以,这样也更统一。 哦不对,其实这个只是加载测试,不是真正运行 bot 的。

@he0119 he0119 merged commit 262b559 into main Dec 11, 2024
6 of 7 checks passed
@he0119 he0119 deleted the build/docker-test branch December 11, 2024 06:16
@he0119 he0119 added the minor label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants