Fix: avoid QQ Gateway receive timeout - #233
Open
shoucandanghehe wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Since NoneBot2 2.5.0, the aiohttp Driver maps
Request(timeout=30.0)to bothws_receive=30andws_close=30, while the websockets Driver maps the same value to open and close timeouts.The QQ Gateway can remain idle for longer than 30 seconds. With the aiohttp Driver, this raises
TimeoutErrorand makes the adapter reconnect every 30 seconds, delaying event delivery.Related behavior was introduced by nonebot/nonebot2#3923.
Solution
Use an explicit
Timeout:connect=30.0read=Noneclose=30.0This preserves bounded connection setup and shutdown without applying an idle timeout to the long-lived receive loop.
Verification
30.0uv run pyteston Python 3.14: 6 passeduv run --python 3.10 pytest: 6 passed