Refactor to kotlin.assert and power-assert: example #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
reviewed
Oct 28, 2023
| response.status shouldBe HttpStatusCode.OK | ||
| response.body<TagsResponse>().tags.toSet() shouldBe emptySet() | ||
| assert(response.status == HttpStatusCode.OK) | ||
| assert(response.body<TagsResponse>().tags.isEmpty()) |
There was a problem hiding this comment.
I think here we need to use == emptyList() in order to get a proper error message from power-assert.
Suggested change
| assert(response.body<TagsResponse>().tags.isEmpty()) | |
| assert(response.body<TagsResponse>().tags == emptyList()) |
There was a problem hiding this comment.
I think the message for isEmpty is good enough, but if you prefer an equality check, I will refactor it. Here is a comparison:
|
@nomisRev don't worry about it, and I hope you are well. I will also refactor the other asserts before resubmitting the review. |
|
Hi @nomisRev, I implemented your suggestions, refactored the rest of the assertions and rebased the latest main. Please review it again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first example for #173