Post article

[arioston]

This PR resolves issue #160

[arioston]

I have some questions:

1 - Since there's no articleId on the specification, how should we proceed with it here?
2 - how should we implement validations?

[nomisRev]

1. I think we need to add an ArticleResponse that matches the specification. So we have 3 models, the one matching the OpenAPI, the one used in our business logic domain, and the one used in our database. The database model is generated by SqlDelight, and is typically ignored by using executeOne { /** transform properties to business logic domain */ }.

2. You can check validations.kt for validation, I think it already includes all validation checks. body, description, title and tags. So something like:

fun NewArticle.validate(): Either<IncorrectInput, NewArticle> =
  zipOrAccumulate(
      title.validTitle(),
      description.validDescription(),
      body.validBody(),
      validTags(tags)
      :: NewArticle
    )
    .mapLeft(::IncorrectInput)

[nomisRev]

Looks really good to me @arioston! I answered your questions, hope that clarifies things.
I'm very sorry for the delay in code review 🙏

Thank you for taking interest in the project 🙌

[nomisRev]

1. I think we need to add an ArticleResponse that matches the specification. So we have 3 models, the one matching the OpenAPI, the one used in our business logic domain, and the one used in our database. The database model is generated by SqlDelight, and is typically ignored by using executeOne { /** transform properties to business logic domain */ }.

2. You can check validations.kt for validation, I think it already includes all validation checks. body, description, title and tags. So something like:

fun NewArticle.validate(): Either<IncorrectInput, NewArticle> =
  zipOrAccumulate(
      title.validTitle(),
      description.validDescription(),
      body.validBody(),
      validTags(tags)
      :: NewArticle
    )
    .mapLeft(::IncorrectInput)

[arioston]

@nomisRev Thank you for all the assistance with those PRs; I have learned a lot.

[nomisRev]

Hey @arioston,
It's my pleasure! I am happy to hear you've learned a lot ☺️ Sorry for the slow review, I was sick all week 🤒

The PR looks perfect, but due to your question of the nullability I think we can optimise some stuff away.

By using a default argument of = emptyList() the parameter remains optional, and we rely on emptyList as a default value. We could've used null, but that is IMHO only valuable if the logic is different depending on the value being present or not. Which is not the case here.

[nomisRev]

Perfect @arioston! Thank you 👏 👏 👏