Use ModelActionX instance #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
lacasseio
force-pushed
the
lacasseio/use-model-action-directly
branch
from
51ec179
to
e26c017
Compare
|
No longer in scope, see #858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To shift toward a more declarable action/job/system execution, we are moving toward isolation and descriptor based. It will allow us to move toward more parallelism as the constraint will follow the action/job/system model. Although the
ModelActionXinstances are more verbose, they fit nicely with our future work. It also allows us to abstract away how the jobs declare their constraints.A quick note on the action/job/system model. Given the internal is closely related to an ECS design, we need to express the System better. At the moment, this aspect is non-existent. The system allows a certain ordering in the rule executions. The Job is what can be scheduled in parallel. It contains the constrain on required components and is executed for each matching entity. Finally, the action is what the developer writes. We are considering making things easier by declaring mutability and some unpacking strategy so we don't always have to deal directly with components/component references.