-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert documentation test from Spock to JUnit 5 #731
Open
lacasseio
wants to merge
27
commits into
master
Choose a base branch
from
lacasseio/convert-docs-test-to-junit5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
This new link checker doesn't give contexts but that should be handled by the assertion instead of the crawler framework. It now create a different JUnit test for each URL to check. Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
We didn't convert all test cases as some are pending analysis to be potentially removed. Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Signed-off-by: Daniel Lacasse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the major cleanup and upgrades we need to improve testing. We started with the documentation tests to showcase performance improvement and thus develop more samples. The documentation tests are also more ad-hoc, so it will stress the approach we take.