Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast randomness #266

Merged
merged 6 commits into from
Sep 24, 2023
Merged

Fast randomness #266

merged 6 commits into from
Sep 24, 2023

Conversation

webmaster128
Copy link
Collaborator

@webmaster128 webmaster128 commented Jul 20, 2023

Closes #248

Copy link
Contributor

@kaisbaccour kaisbaccour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed this looks super amazing. Well done.
One suggestion maybe for the future, maybe for now. How about removing the INCENTIVISED_ROUNDS entries when the slowest incentivised bot submits the randomness.
So first bot submits then second then third .... the 6th bot removes the KV entry.

@webmaster128
Copy link
Collaborator Author

One suggestion maybe for the future, maybe for now. How about removing the INCENTIVISED_ROUNDS entries when the slowest incentivised bot submits the randomness.
So first bot submits then second then third .... the 6th bot removes the KV entry.

Good idea! I started adding it but I think it's better to do it as part of #154. Then we can do all cleanups for a round together and bump config.min_round as a way to finalize those rounds.

@kaisbaccour
Copy link
Contributor

One suggestion maybe for the future, maybe for now. How about removing the INCENTIVISED_ROUNDS entries when the slowest incentivised bot submits the randomness.
So first bot submits then second then third .... the 6th bot removes the KV entry.

Good idea! I started adding it but I think it's better to do it as part of #154. Then we can do all cleanups for a round together and bump config.min_round as a way to finalize those rounds.

This is not only for cleanup but also to make sure new bots don't try to submit to that requested round. or is that already the case because after the 6th it becomes not incentivised ?

@webmaster128
Copy link
Collaborator Author

or is that already the case because after the 6th it becomes not incentivised ?

This part does not change:

    // Check if the bot is fast enough to get an incentive
    if submissions_count < NUMBER_OF_INCENTIVES_PER_ROUND {
        reward_points += INCENTIVE_POINTS_FOR_FAST_BOT;
    }

So for both mod10 rounds and job rounds we have up to 6 incentivised submissions

@kaisbaccour
Copy link
Contributor

or is that already the case because after the 6th it becomes not incentivised ?

This part does not change:

    // Check if the bot is fast enough to get an incentive
    if submissions_count < NUMBER_OF_INCENTIVES_PER_ROUND {
        reward_points += INCENTIVE_POINTS_FOR_FAST_BOT;
    }

So for both mod10 rounds and job rounds we have up to 6 incentivised submissions

Okay clear, thanks

@webmaster128 webmaster128 force-pushed the fast-randomness branch 3 times, most recently from de0e4a1 to 55f0af8 Compare September 2, 2023 22:01
@webmaster128 webmaster128 marked this pull request as ready for review September 2, 2023 22:08
@webmaster128 webmaster128 merged commit 1c57308 into main Sep 24, 2023
17 checks passed
@webmaster128 webmaster128 deleted the fast-randomness branch September 24, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow all drand rounds
2 participants