-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast randomness #266
Fast randomness #266
Conversation
5818f43
to
52ef12d
Compare
54282d3
to
b6b8257
Compare
b6b8257
to
94d6c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed this looks super amazing. Well done.
One suggestion maybe for the future, maybe for now. How about removing the INCENTIVISED_ROUNDS entries when the slowest incentivised bot submits the randomness.
So first bot submits then second then third .... the 6th bot removes the KV entry.
94d6c7c
to
683ad55
Compare
683ad55
to
8ae1994
Compare
8ae1994
to
5a84000
Compare
Good idea! I started adding it but I think it's better to do it as part of #154. Then we can do all cleanups for a round together and bump |
This is not only for cleanup but also to make sure new bots don't try to submit to that requested round. or is that already the case because after the 6th it becomes not incentivised ? |
This part does not change:
So for both mod10 rounds and job rounds we have up to 6 incentivised submissions |
Okay clear, thanks |
de0e4a1
to
55f0af8
Compare
55f0af8
to
9fb3aba
Compare
Closes #248