Fix jobs checking #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
commented
Apr 14, 2024
|
|
||
| // Use jobs_asc because with jobs_desc all entries in the result might be in the (far) future, | ||
| // leading to cases where the unprocesses jobs in the past are not processed anymore. | ||
| const query = { jobs_asc: { offset: null, limit: queryLimit } }; |
There was a problem hiding this comment.
This jobs_desc -> jobs_asc is the main change here
kaisbaccour
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
This is amazing. I was a bit worried with the 50 limit because it's something we would always have to check and that wouldn't be scalable/maintainable unless we remove getRandomnessAfter(). With this change even a limit of 1 would eventually process all jobs. Thank you so much.
Handling the sequence mismatch is also great. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the jobs were loaded in descending order. This could lead to situations where the result only contained future rounds because it was limited. The rounds in the past would remain behind the limit and only processed if there are no future round anymore.