Semantic: duplicate fields

nois-lang · Mar 30, 2024 · dec6df0 · dec6df0
1 parent 299fad1
commit dec6df0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/semantic/index.ts b/src/semantic/index.ts
@@ -549,10 +549,13 @@ const checkVariant = (variant: Variant, ctx: Context) => {
 
     const module = ctx.moduleStack.at(-1)!
     const typeDefScope = <TypeDefScope>module.scopeStack.at(-1)!
-    variant.fieldDefs.forEach(fieldDef => {
+    variant.fieldDefs.forEach((fieldDef, i) => {
         checkType(fieldDef.fieldType, ctx)
         fieldDef.type = typeToVirtual(fieldDef.fieldType, ctx)
-        // TODO: check duplicate field defs
+
+        if (variant.fieldDefs.slice(0, i).some(f => f.name.value === fieldDef.name.value)) {
+            addError(ctx, duplicateError(ctx, fieldDef.name, fieldDef.name.value, 'field'))
+        }
     })
 
     const generics = [...typeDefScope.definitions.values()].map(d => <Generic>d).map(g => genericToVirtual(g, ctx))

diff --git a/src/semantic/semantic.spec.ts b/src/semantic/semantic.spec.ts
@@ -707,6 +707,12 @@ type Foo {
             const ctx = check(code)
             expect(ctx.errors.map(e => e.message)).toEqual(['duplicate variant `A`'])
         })
+
+        it('duplicate field', () => {
+            const code = `type Foo(a: Int, a: String)`
+            const ctx = check(code)
+            expect(ctx.errors.map(e => e.message)).toEqual(['duplicate field `a`'])
+        })
     })
 
     describe('fn def', () => {