Semantic: print notes

nois-lang · Mar 16, 2024 · 0b058c9 · 0b058c9
1 parent dbdcdf5
commit 0b058c9
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 8 deletions.
diff --git a/src/error.ts b/src/error.ts
@@ -31,9 +31,10 @@ export const colorWarning = (message: string): string => {
     return yellow(message)
 }
 
-export const prettySourceMessage = (message: string, span: Span, source: Source): string => {
+export const prettySourceMessage = (message: string, span: Span, source: Source, notes: string[] = []): string => {
     const start = indexToLocation(span.start, source)!
     const locationStr = `${source.filepath}:${locationToString(start)}`
     const locationMsg = `  at ${locationStr}`
-    return [message, locationMsg, prettyLineAt(span, source)].join('\n')
+    const notesStr = notes.length > 0 ? notes.map(n => `  note: ${n}`).join('\n') : ''
+    return [message, locationMsg, prettyLineAt(span, source), notesStr].filter(s => s.length > 0).join('\n')
 }
diff --git a/src/index.ts b/src/index.ts
@@ -142,15 +142,25 @@ assert(ctx.moduleStack.length === 0, ctx.moduleStack.length.toString())
 if (ctx.errors.length > 0) {
     for (const error of ctx.errors) {
         console.error(
-            prettySourceMessage(colorError(error.message), getSpan(error.node.parseNode), error.module.source)
+            prettySourceMessage(
+                colorError(error.message),
+                getSpan(error.node.parseNode),
+                error.module.source,
+                error.notes
+            )
         )
     }
     process.exit(1)
 }
 
 for (const warning of ctx.warnings) {
     console.error(
-        prettySourceMessage(colorWarning(warning.message), getSpan(warning.node.parseNode), warning.module.source)
+        prettySourceMessage(
+            colorWarning(warning.message),
+            getSpan(warning.node.parseNode),
+            warning.module.source,
+            warning.notes
+        )
     )
 }
 

diff --git a/src/semantic/error.ts b/src/semantic/error.ts
@@ -27,8 +27,13 @@ export const semanticError = (
     notes: string[] = []
 ): SemanticError => ({ code, module: ctx.moduleStack.at(-1)!, node, message, notes })
 
-export const notFoundError = (ctx: Context, node: AstNode<any>, id: string, kind: string = node.kind): SemanticError =>
-    semanticError(1, ctx, node, `${kind} \`${id}\` not found`)
+export const notFoundError = (
+    ctx: Context,
+    node: AstNode<any>,
+    id: string,
+    kind: string = 'identifier',
+    notes?: string[]
+): SemanticError => semanticError(1, ctx, node, `${kind} \`${id}\` not found`, notes)
 
 export const notImplementedError = (ctx: Context, node: AstNode<any>, message?: string): SemanticError =>
     semanticError(2, ctx, node, `not implemented:${message ? ` ${message}` : ''}`)

diff --git a/src/semantic/instance.ts b/src/semantic/instance.ts
@@ -147,8 +147,8 @@ const checkMethodCallExpr = (
         const fieldType = checkFieldAccessExpr(lOperand, identifier, ctx)
         ctx.silent = false
         if (fieldType) {
-            // TODO: add note
-            addError(ctx, notFoundError(ctx, identifier, vidToString(methodVid), 'method'))
+            const note = `to access field \`${methodName}\`, surround operand in parentheses`
+            addError(ctx, notFoundError(ctx, identifier, vidToString(methodVid), 'method', [note]))
         } else {
             addError(ctx, notFoundError(ctx, identifier, vidToString(methodVid), 'method'))
         }