Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support smaller jsonblobs #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

zac-williamson
Copy link
Collaborator

Description

Adds support for 128 byte and 256 byte json blobs

Problem*

When fuzzing this library, having smaller json objects helps speed up tests

Summary*

JSON128b and JSON256b are new classes in lib.nr

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kashbrti
Copy link
Contributor

kashbrti commented Jan 8, 2025

@zac-williamson, I currently have a PR that is fixing the nightly fails and making the workflow a bit better. It'd be best to wait for that to get merged in before going further with this if it's not super urgent.

@TomAFrench
Copy link
Member

Can you build this PR on top of #19? Implementing a new struct to just hide generics is very sad.

@zac-williamson
Copy link
Collaborator Author

Can you build this PR on top of #19? Implementing a new struct to just hide generics is very sad.

oh nice! Yes I was meaning to restructure the lib but never had enough time. Will do so

@kashbrti
Copy link
Contributor

kashbrti commented Jan 8, 2025

I approved #19. @TomAFrench you could merge that in and we could merge main into this branch?

@TomAFrench
Copy link
Member

#19 is merged now btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants