-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update to support Noir 0.37.0 #16
Conversation
I'm failing to run the formatter. Here's the error I'm getting. It's a bit weird that it panics because I can compile and also the tests pass.
|
# Description ## Problem Resolves noir-lang/noir_json_parser#16 (comment) ## Summary I thought for "op assign" like `x += 1` there will always come one or two tokens, then `=`, but that's not the case for `>>=` (it's `> >=`). ## Additional Context ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
|
Right, I made some changes to the formatter after 0.36.0 was released because otherwise it destroyed all the formatting that exists in the array literals here. |
I think it works with nightly just not with 0.36.0. should we just go ahead and merge this? |
It'll need the formatter to be disabled first if we're going to merge without it. |
Description
fixed the issues with the new release
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.