Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use clip for gradient clipping #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliverdutton
Copy link

@oliverdutton oliverdutton commented Mar 9, 2022

Using jnp.clip (or the lower level lax.max(x, eps)) deals with gradients. Avoiding the need for the 'double where' trick.

@Olllom Olllom requested a review from jonkhler March 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant