fix(retry): forward rawHeaders writes through RetryController - #5727
Open
official-burak wants to merge 1 commit into
Open
fix(retry): forward rawHeaders writes through RetryController#5727official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Decompress assigns controller.rawHeaders when stripping content-encoding. The retry proxy only had getters, so compose([retry, decompress]) threw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5726
RetryControllerforwardedrawHeaders/rawTrailersas getters only.DecompressHandlerassigns a filtered list ontocontroller.rawHeaderswhen it stripscontent-encoding, so the documented ordercompose([retry(), decompress()])threw:This adds setters that write through to the active connection controller (no-ops before a connection is attached, same as
pause/resume).Tests
test/retry-handler-controller-proxy.jsfailed with the getter-only TypeError;retry composed before decompress can rewrite rawHeadersfailed.