types: expose PendingInterceptor and PendingInterceptorsFormatter on the MockAgent namespace - #5721
Open
RaphaelFakhri wants to merge 1 commit into
Open
Conversation
…m MockAgent Both interfaces were declared at the top level of the module and never exported, so a consumer typing a helper around pendingInterceptors() had no way to name their argument and had to copy the declaration, which then drifts. Move them under the MockAgent namespace and point the two members at the namespaced names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5563.
Both interfaces are declared at the top level of
types/mock-agent.d.tsand never exported, so a consumer writing a helper aroundpendingInterceptors(), or a custompendingInterceptorsFormatter, has no way to name the argument type and ends up copying the declaration into their own code, where it then drifts from this one.They move into the
MockAgentnamespace, next toOptionsand the other public members, and the two class members now point at the namespaced names. Nothing else intypes/orindex.d.tsreferenced them, so this is additive for consumers and a no-op for the existing declarations.test/types/mock-agent.test-d.tsgains an assertion that both names are reachable asMockAgent.PendingInterceptorandMockAgent.PendingInterceptorsFormatterfrom outside the module.