Skip to content

ci: reenable shared builtin CI tests#4967

Open
mcollina wants to merge 1 commit intofix/websocket-http1-fallbackfrom
ci/reenable-shared-builtin-tests
Open

ci: reenable shared builtin CI tests#4967
mcollina wants to merge 1 commit intofix/websocket-http1-fallbackfrom
ci/reenable-shared-builtin-tests

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Apr 3, 2026

Summary

Re-enable the shared builtin CI workflow for supported/current Node.js majors.

Changes

  • run the shared builtin CI job for Node.js 24 and 25 again
  • include Node.js 26 so the reusable workflow will start testing it automatically once a release is available
  • keep Node.js 20 and 22 excluded, with a note that they still hit upstream Node.js issues with --shared-builtin-undici/undici-path

Notes

The reusable workflow already skips unreleased versions cleanly, so including Node.js 26 here is safe.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina force-pushed the ci/reenable-shared-builtin-tests branch from 816e90d to 615df31 Compare April 3, 2026 14:38
@mcollina mcollina changed the base branch from main to fix/websocket-http1-fallback April 3, 2026 14:38
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (1694d12) to head (615df31).
⚠️ Report is 1 commits behind head on fix/websocket-http1-fallback.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           fix/websocket-http1-fallback    #4967   +/-   ##
=============================================================
  Coverage                         92.96%   92.96%           
=============================================================
  Files                               111      111           
  Lines                             35856    35856           
=============================================================
  Hits                              33334    33334           
  Misses                             2522     2522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants