Skip to content

refactor: FunctionSignature return type container #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canerakdas wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: FunctionSignature return type container #8717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ee995
refactor: function return type container
canerakdas Mar 12, 2026
d4e198e
chore: patch and unique key
canerakdas Mar 12, 2026
01dff78
chore: remove unnecessary container
canerakdas Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@node-core/ui-components",
"version": "1.6.2",
"version": "1.6.3",
"type": "module",
"exports": {
"./*": {
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-components/src/Common/Signature/SignatureRoot/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
}

.root {
@apply flex
@apply mb-3
flex
flex-col
gap-4
rounded-sm
Expand Down
11 changes: 11 additions & 0 deletions packages/ui-components/src/Containers/FunctionSignature/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,17 @@ export const Nested: Story = {
},
],
},
{
name: 'Returns',
kind: 'return',
description: 'description',
type: (
<>
<a href="#">&lt;Promise&gt;</a>|
<a href="#">&lt;AsyncIterable&gt;</a>
</>
),
},
],
},
};
Expand Down
20 changes: 17 additions & 3 deletions packages/ui-components/src/Containers/FunctionSignature/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,24 @@ const renderSignature = (param: SignatureDefinition, index: number) => (

const FunctionSignature: FC<FunctionSignatureProps> = ({ title, items }) => {
if (title) {
const attributes: Array<SignatureDefinition> = [];
Copy link
Member

@araujogui araujogui Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would:

const { attributes, returnTypes } = items.reduce(
  (acc, item) => {
    (item.kind === 'return' ? acc.returnTypes : acc.attributes).push(item);
    return acc;
  },
  { attributes: [] as SignatureDefinition[], returnTypes: [] as SignatureDefinition[] }
);

Copy link
Member

@araujogui araujogui Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

const attributes: SignatureDefinition[] = [];
const returnTypes: SignatureDefinition[] = [];

for (const item of items) {
  const target = item.kind === 'return' ? returnTypes : attributes;
  target.push(item);
}

const returnTypes: Array<SignatureDefinition> = [];

for (const item of items) {
(item.kind === 'return' ? returnTypes : attributes).push(item);
}

return (
<Signature title={title}>
{items.map((param, i) => renderSignature(param, i))}
</Signature>
<>
<Signature title={title}>
{attributes.map((param, i) => renderSignature(param, i))}
</Signature>

{returnTypes.length > 0 &&
returnTypes.map((param, i) =>
renderSignature(param, attributes.length + i)
)}
</>
);
}

Expand Down
Loading