-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: Node.js references in release posts #7998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Our guidelines indicates we should be using _Node.js_ instead of _Node_. Refs: https://github.com/nodejs/node/blob/668e52339261ec21c7388884620987914c833395/doc/README.md#L213-L216
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request standardizes Node.js naming conventions by updating release post titles from "Node" to "Node.js" according to official Node.js style guidelines. The changes affect hundreds of release announcement files spanning from v0.4.4 through v14.17.3.
- Updates all release post titles to use the consistent "Node.js" naming format
- Maintains consistent branding across historical release announcements
- Aligns with Node.js project style guidelines for proper project name usage
Reviewed Changes
Copilot reviewed 300 out of 715 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
v14.x release files | Updated 13 Node.js v14 release post titles from "Node" to "Node.js" |
v13.x release files | Updated 21 Node.js v13 release post titles from "Node" to "Node.js" |
v12.x release files | Updated 47 Node.js v12 release post titles from "Node" to "Node.js" |
v11.x release files | Updated 14 Node.js v11 release post titles from "Node" to "Node.js" |
v10.x release files | Updated 43 Node.js v10 release post titles from "Node" to "Node.js" |
v0.x release files | Updated 184+ legacy Node.js release post titles from "Node" or variants to "Node.js" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7998 +/- ##
==========================================
+ Coverage 73.09% 73.12% +0.03%
==========================================
Files 95 95
Lines 8354 8354
Branches 219 218 -1
==========================================
+ Hits 6106 6109 +3
+ Misses 2247 2244 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the release-post script, as all of them are automatically generated.
Antoine do it, he updated the template |
Lighthouse Results
|
Our guidelines indicates we should be using Node.js instead of Node.
Refs: https://github.com/nodejs/node/blob/668e52339261ec21c7388884620987914c833395/doc/README.md#L213-L216
Description
Validation
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.