Skip to content

Update nodejs-the-difference-between-development-a… for gramatical error #7859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sukanta47
Copy link

@sukanta47 sukanta47 commented Jun 11, 2025

…nd-production.md

There was a gramatical error in the sentence: "...where our application is run:" has been amended to "...where our application runs:"

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

…nd-production.md

There was a gramatical error in the sentence: "...where our application is run:" has been amended to "...where our application runs"

Signed-off-by: Sukanta Biswas <[email protected]>
@sukanta47 sukanta47 requested a review from a team as a code owner June 11, 2025 12:21
Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 11, 2025 0:22am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both work. I don't see real improvement

@sukanta47
Copy link
Author

Both work. I don't see real improvement

Not exactly, I think my correction makes it grammatically correct. The existing sentence doesn't sound appropriate.

@avivkeller
Copy link
Member

avivkeller commented Jun 12, 2025

Both sentences are grammatically correct. The only difference is that your sentence is active, and the previous one was passive.

If I understand correctly, it's fine to assume that the application is being run by an external agent, which means using a passive voice is grammatically correct, along with an active one.

@AugustinMauroy
Copy link
Member

agree with Aviv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants