chore: Apply ESLint rule (object-shorthand) #7851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
canerakdas
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enforces the ESLint object-shorthand rule across the site codebase and updates the import of importX to use its flatConfigs API.
- Converted all object literals to use explicit
key: valueform (to satisfy the new rule configuration). - Updated
eslint-plugin-import-ximport to pull inflatConfigscorrectly. - Cleaned up related warnings in various reducers, components, and generators.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/site/reducers/releaseReducer.ts | Expanded dispatch payload shorthand to explicit props |
| apps/site/next.rewrites.mjs | Converted shorthand destination to destination: destination |
| apps/site/next.mdx.use.mjs | Updated component mapping to explicit shorthand form |
| apps/site/next.dynamic.mjs | Converted route mapping shorthand to full props |
| apps/site/next.calendar.mjs | Converted URLSearchParams shorthand to explicit props |
| apps/site/next-data/generators/websiteFeeds.mjs | Expanded date shorthand to date: date |
| apps/site/next-data/generators/releaseData.mjs | Removed redundant fetch: key, expanded other shorthands |
| apps/site/next-data/generators/blogData.mjs | Converted blog metadata shorthand to full object fields |
| apps/site/next-data/generators/tests/websiteFeeds.test.mjs | Updated test object shorthand for date property |
| apps/site/layouts/Blog.tsx | Converted return shorthand to explicit field: field |
| apps/site/i18n.tsx | Expanded locale shorthand to locale: locale |
| apps/site/hooks/react-generic/useSiteNavigation.ts | Converted navigation mapping shorthand to full props |
| apps/site/eslint.config.js | Updated import of importX to flatConfigs |
| apps/site/components/withNavBar.tsx | Converted prop shorthand to link: link, target: target |
| apps/site/components/withFooter.tsx | Expanded navigation object shorthand |
| apps/site/components/withBreadcrumbs.tsx | Converted breadcrumbs mapping to full props |
| apps/site/components/withAvatarGroup.tsx | Converted avatar group props shorthand |
| apps/site/app/[locale]/page.tsx | Expanded sharedContext shorthands |
| apps/site/app/[locale]/next-data/page-data/route.ts | Renamed deflatedSource to content and expanded shorthand |
| apps/site/app/[locale]/next-data/api-data/route.ts | Expanded shorthand filename |
Comments suppressed due to low confidence (1)
apps/site/next.mdx.use.mjs:15
- [nitpick] Good use of shorthand here; ensure consistency across similar mappings.
DownloadReleasesTable,
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #7851 +/- ##
==========================================
+ Coverage 75.44% 75.49% +0.04%
==========================================
Files 101 101
Lines 8305 8316 +11
Branches 218 218
==========================================
+ Hits 6266 6278 +12
+ Misses 2037 2036 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
5 tasks
AugustinMauroy
approved these changes
Jun 8, 2025
araujogui
reviewed
Jun 10, 2025
| @@ -44,6 +44,7 @@ export default [ | |||
| }, | |||
| }, | |||
| ], | |||
| 'object-shorthand': ['error', 'consistent-as-needed'], | |||
There was a problem hiding this comment.
I don't know if consistent-as-needed is needed, I don't see a problem mixing shorthand and non-shorthand properties.
There was a problem hiding this comment.
I think it's better to define the code style clearly from the beginning for future contributors. If mixing shorthand properties isn't an issue for everyone, it's fine by me too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We intend to add this as a rule based on the feedback received during code reviews, so it applies consistently across the website for all contributors and helps maintain the code style.
See; (https://eslint.org/docs/latest/rules/object-shorthand)
Additionally, cleaned up the
importXimports that were given warnings in the project