Skip to content

chore: use catalog for dependencies across multiple packages and the website #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use catalog for dependencies across multiple packages and the website #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@
"@radix-ui/react-toast": "^1.2.6",
"@radix-ui/react-tooltip": "^1.2.4",
"@tailwindcss/postcss": "~4.1.5",
"@types/node": "22.15.3",
"@types/react": "^19.1.0",
"@types/node": "catalog:",
"@types/react": "catalog:",
"@vcarl/remark-headings": "~0.1.0",
"@vercel/analytics": "~1.5.0",
"@vercel/otel": "~1.11.0",
"@vercel/speed-insights": "~1.2.0",
"classnames": "~2.5.1",
"classnames": "catalog:",
"cross-env": "7.0.3",
"feed": "~4.2.2",
"github-slugger": "~2.0.0",
Expand All @@ -60,7 +60,7 @@
"next-intl": "~4.1.0",
"next-themes": "~0.4.6",
"postcss-calc": "~10.1.1",
"react": "^19.1.0",
"react": "catalog:",
"react-dom": "^19.1.0",
"reading-time": "~1.5.0",
"rehype-autolink-headings": "~7.1.0",
Expand All @@ -69,7 +69,7 @@
"remark-reading-time": "~2.0.1",
"semver": "~7.7.1",
"sval": "^0.6.3",
"tailwindcss": "~4.0.17",
"tailwindcss": "catalog:",
"vfile": "~6.0.3",
"vfile-matter": "~5.0.1"
},
Expand Down Expand Up @@ -106,7 +106,7 @@
"stylelint-order": "7.0.0",
"stylelint-selector-bem-pattern": "4.0.1",
"tsx": "^4.19.3",
"typescript": "~5.8.2",
"typescript": "catalog:",
"typescript-eslint": "~8.31.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add typescript-eslint?

"user-agent-data-types": "0.4.2",
"wrangler": "^4.13.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"devDependencies": {
"eslint-import-resolver-typescript": "~4.3.1",
"typescript": "~5.8.2",
"typescript": "catalog:",
"typescript-eslint": "~8.31.1"
}
}
2 changes: 1 addition & 1 deletion packages/rehype-shiki/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"dependencies": {
"@shikijs/core": "^3.3.0",
"@shikijs/engine-javascript": "^3.3.0",
"classnames": "~2.5.1",
"classnames": "catalog:",
"hast-util-to-string": "^3.0.1",
"shiki": "~3.3.0",
"unist-util-visit": "^5.0.0"
Expand Down
12 changes: 6 additions & 6 deletions packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
"@radix-ui/react-tooltip": "~1.2.4",
"@tailwindcss/postcss": "~4.1.5",
"@vcarl/remark-headings": "~0.1.0",
"classnames": "~2.5.1",
"classnames": "catalog:",
"postcss-calc": "^10.1.1",
"tailwindcss": "~4.0.17"
"tailwindcss": "catalog:"
},
"devDependencies": {
"@storybook/addon-controls": "^8.6.12",
Expand All @@ -58,23 +58,23 @@
"@storybook/react": "^8.6.12",
"@storybook/react-webpack5": "^8.6.12",
"@testing-library/user-event": "~14.6.1",
"@types/node": "22.15.3",
"@types/react": "^19.1.0",
"@types/node": "catalog:",
"@types/react": "catalog:",
"cross-env": "^7.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add cross-env

"css-loader": "~7.1.2",
"eslint-plugin-react": "~7.37.4",
"eslint-plugin-storybook": "~0.12.0",
"global-jsdom": "^26.0.0",
"postcss-loader": "~8.1.1",
"react": "^19.1.0",
"react": "catalog:",
"storybook": "^8.6.11",
"style-loader": "~4.0.0",
"stylelint": "^16.19.1",
"stylelint-config-standard": "^38.0.0",
"stylelint-order": "7.0.0",
"stylelint-selector-bem-pattern": "4.0.1",
"tsx": "^4.19.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add our testing deps, like tsx JSdom, etc?

"typescript": "~5.8.2",
"typescript": "catalog:",
"typescript-eslint": "~8.31.1"
},
"imports": {
Expand Down
96 changes: 39 additions & 57 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,16 @@ onlyBuiltDependencies:
- esbuild
- sharp
- unrs-resolver

# We use catalog for dependencies that are shared across
# multiple packages in the monorepo.
# This allows us to manage versions and updates in one place.
# https://pnpm.io/en/catalogs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

catalog:
'@types/node': 22.15.3
'@types/react': ^19.1.0
classnames: ~2.5.1
react: ^19.1.0
tailwindcss: ~4.0.17
typescript: ~5.8.2
Comment on lines +20 to +26
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the dependencies I saw repeated more than once across all the packages and the website. Feel free to suggest any that might be missing.

Loading